-
Notifications
You must be signed in to change notification settings - Fork 122
feat: add redis support in shopify pixel for id stitching #3957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1bf1716
feat: add redis support in shopify pixel for id stitching
yashasvibajpai 3307122
chore: update redis set structure
yashasvibajpai 0c8251b
chore: update attribute name
yashasvibajpai 17cb53b
fix: stitched events through redis in pixel
yashasvibajpai 306821e
fix: stitched events through redis in pixel
yashasvibajpai cf14695
fix: stitched events through redis in pixel
yashasvibajpai 4fa1c41
chore: add tests
yashasvibajpai e285d8b
Merge branch 'develop' into chore.redis.support.shopify.pixel
yashasvibajpai 7f57e45
chore: add campaign object support in web pixel events (#3973)
yashasvibajpai 0fbe91a
chore: address comments
yashasvibajpai b747193
chore: remove unnecessary check in carttoken fetching
yashasvibajpai 581bcfe
chore: improve sonal quality
yashasvibajpai 228564d
chore: improve sonar quality
yashasvibajpai 372b025
Merge branch 'develop' into chore.redis.support.shopify.pixel
krishna2020 41169e0
Merge branch 'develop' into chore.redis.support.shopify.pixel
yashasvibajpai f47e618
chore: handle sonar cognetive quality check
yashasvibajpai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
const { RedisDB } = require('../../../util/redis/redisConnector'); | ||
|
||
const NO_OPERATION_SUCCESS = { | ||
outputToSource: { | ||
body: Buffer.from('OK').toString('base64'), | ||
contentType: 'text/plain', | ||
}, | ||
statusCode: 200, | ||
}; | ||
|
||
const isIdentifierEvent = (payload) => ['rudderIdentifier'].includes(payload?.event); | ||
|
||
const processIdentifierEvent = async (event) => { | ||
const { cartToken, anonymousId } = event; | ||
await RedisDB.setVal(`${cartToken}`, ['anonymousId', anonymousId]); | ||
return NO_OPERATION_SUCCESS; | ||
}; | ||
|
||
module.exports = { | ||
processIdentifierEvent, | ||
isIdentifierEvent, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
const { isIdentifierEvent, processIdentifierEvent } = require('./utils'); | ||
const { RedisDB } = require('../../../util/redis/redisConnector'); | ||
|
||
describe('Identifier Utils Tests', () => { | ||
describe('test isIdentifierEvent', () => { | ||
it('should return true if the event is rudderIdentifier', () => { | ||
const event = { event: 'rudderIdentifier' }; | ||
expect(isIdentifierEvent(event)).toBe(true); | ||
}); | ||
|
||
it('should return false if the event is not rudderIdentifier', () => { | ||
const event = { event: 'checkout started' }; | ||
expect(isIdentifierEvent(event)).toBe(false); | ||
}); | ||
}); | ||
|
||
describe('test processIdentifierEvent', () => { | ||
beforeEach(() => { | ||
jest.clearAllMocks(); | ||
}); | ||
|
||
it('should set the anonymousId in redis and return NO_OPERATION_SUCCESS', async () => { | ||
const setValSpy = jest.spyOn(RedisDB, 'setVal').mockResolvedValue('OK'); | ||
const event = { cartToken: 'cartTokenTest1', anonymousId: 'anonymousIdTest1' }; | ||
|
||
const response = await processIdentifierEvent(event); | ||
|
||
expect(setValSpy).toHaveBeenCalledWith('cartTokenTest1', ['anonymousId', 'anonymousIdTest1']); | ||
expect(response).toEqual({ | ||
outputToSource: { | ||
body: Buffer.from('OK').toString('base64'), | ||
contentType: 'text/plain', | ||
}, | ||
statusCode: 200, | ||
}); | ||
}); | ||
|
||
it('should handle redis errors', async () => { | ||
jest.spyOn(RedisDB, 'setVal').mockRejectedValue(new Error('Redis connection failed')); | ||
const event = { cartToken: 'cartTokenTest1', anonymousId: 'anonymousIdTest1' }; | ||
|
||
await expect(processIdentifierEvent(event)).rejects.toThrow('Redis connection failed'); | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.