Fixed expectRevert being applied to calls to cheatcodes#1012
Merged
automergerpr-permission-manager[bot] merged 13 commits intomasterfrom Nov 26, 2025
Merged
Fixed expectRevert being applied to calls to cheatcodes#1012automergerpr-permission-manager[bot] merged 13 commits intomasterfrom
automergerpr-permission-manager[bot] merged 13 commits intomasterfrom
Conversation
anvacaru
reviewed
Apr 10, 2025
anvacaru
reviewed
Apr 10, 2025
lisandrasilva
commented
Apr 11, 2025
palinatolmach
approved these changes
Nov 24, 2025
Contributor
palinatolmach
left a comment
palinatolmach
left a comment
There was a problem hiding this comment.
Looks good, and I think it's reasonable leave the delegatecall investigation to a follow-up PR.
anvacaru
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
expectRevertcheatcode implementation. According to the Foundry documentation:In the previous implementation, the call to the cheatcode was being ignored in the sense that was not being executed. This PR still executes cheatcode calls but does not check if these calls revert or not.
Fixes #993.