Fix a few missed cases of "vXY and later only" in types#517
Merged
tcharding merged 2 commits intorust-bitcoin:masterfrom Feb 24, 2026
Merged
Fix a few missed cases of "vXY and later only" in types#517tcharding merged 2 commits intorust-bitcoin:masterfrom
tcharding merged 2 commits intorust-bitcoin:masterfrom
Conversation
Remove some remaining version ranges from the RPC fields. Add missing full stops. Change the docs of two into_model functions to match the rest of them.
One of the fields in types for PeerInfo was marked as "(deprecated in v0.21)" and set as an option in v22 and v26. The field is not in the RPC docs for wither v22 or v26 and the tests pass with it being removed. Remove the deprecated `whitelisted` field from `PeerInfo`.
tcharding
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#513 missed a few cases of "vXY and later only" comments that had different wording and didn't come up in the grep. Do a more general search and fix what is found.
One of the fields in types for
PeerInfowas marked as "(deprecated in v0.21)" and set as an option in v22 and v26. The field is not in the RPC docs for either v22 or v26 and the tests pass with it being removed.whitelistedfield fromPeerInfo.