-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dist): add notes for stable
and beta
in components_missing_msg()
#3920
Conversation
d463ca8
to
4e5d115
Compare
Co-authored-by: Robert Collins <[email protected]>
4e5d115
to
1f976a6
Compare
1f976a6
to
5667e49
Compare
5667e49
to
d5f257b
Compare
d5f257b
to
58b7dba
Compare
@onur-ozkan My apologies for getting a bit sidetracked previously! I would like to know how https://rust-lang.github.io/rustup-components-history will behave on the removal of IMHO, it should also include a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components in case someone wonders why |
I couldn't find any hard-coded logic in https://github.com/rust-lang/rustup-components-history. I think it will just disappear without causing any issues.
That sounds great but I don't know who maintains it. |
|
I'm happy to merge small PRs to rustup-components-history. |
Prepares for
rls
' removal in the release channel.Continuation of #3453, as requested by @onur-ozkan in rust-lang/rust#126856 (comment).
The error message is not final, since I'd still like to add a link that provides more info about removed components (which isThe message now includes a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components.rls
this time):Concerns
To which document should we add the list of removed components?To the Rustup User Guide, see above for details.Should the note be applied toNo, as feat(html): add a link to removed components rustup-components-history#54 will add a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components on the components history page.nightly
as well?