Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dist): add notes for stable and beta in components_missing_msg() #3920

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jul 2, 2024

Prepares for rls' removal in the release channel.

Continuation of #3453, as requested by @onur-ozkan in rust-lang/rust#126856 (comment).

The best thing we could do is to add a note saying some components may no longer be available (this note currently doesn't apply for stables), but:

  1. We'll have to wait for v1.28 to ship it, and we're currently in the middle of the release cycle (we have limited bandwidth so we decided not to do backports), and
  2. We should not hardcode the list of removed components in Rustup

https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/excluding.20rls.20from.20the.20release/near/447968780

The error message is not final, since I'd still like to add a link that provides more info about removed components (which is rls this time): The message now includes a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components.

... and for this I suggest adding a section in the Rust docs somewhere, and our notes should advise the user to check out the section above to see whether the component in question is missing as intended from what date (and if that is the case, they can choose to unblock the update with a clear consent by removing the component).

But in any way we cannot simply skip RLS in an update if it's previously installed, since that would be a real backwards compatibility problem.
https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/excluding.20rls.20from.20the.20release/near/447968780

Concerns

@rami3l rami3l added this to the 1.28.0 milestone Jul 2, 2024
@rami3l rami3l requested a review from djc July 2, 2024 15:03
src/dist/mod.rs Outdated Show resolved Hide resolved
src/dist/mod.rs Show resolved Hide resolved
src/dist/mod.rs Outdated Show resolved Hide resolved
@rami3l rami3l force-pushed the feat/missing-components-pt-2 branch from d463ca8 to 4e5d115 Compare August 12, 2024 10:20
Co-authored-by: Robert Collins <[email protected]>
@rami3l rami3l force-pushed the feat/missing-components-pt-2 branch from 4e5d115 to 1f976a6 Compare August 12, 2024 10:21
@rami3l rami3l force-pushed the feat/missing-components-pt-2 branch from 1f976a6 to 5667e49 Compare August 12, 2024 10:32
@rami3l rami3l force-pushed the feat/missing-components-pt-2 branch from 5667e49 to d5f257b Compare August 12, 2024 10:38
@rami3l rami3l force-pushed the feat/missing-components-pt-2 branch from d5f257b to 58b7dba Compare August 12, 2024 10:43
@rami3l rami3l marked this pull request as ready for review August 12, 2024 10:44
@rami3l rami3l requested a review from djc August 12, 2024 10:44
@rami3l
Copy link
Member Author

rami3l commented Aug 12, 2024

  • Should the note be applied to nightly as well?

@onur-ozkan My apologies for getting a bit sidetracked previously! I would like to know how https://rust-lang.github.io/rustup-components-history will behave on the removal of rls, since we include this link in the message for nightly users.

IMHO, it should also include a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components in case someone wonders why rls is gone in consecutive nightlies starting from a certain date.

@rami3l rami3l requested a review from rbtcollins August 12, 2024 10:50
@onur-ozkan
Copy link
Member

@onur-ozkan My apologies for getting a bit sidetracked previously! I would like to know how https://rust-lang.github.io/rustup-components-history will behave on the removal of rls, since we include this link in the message for nightly users.

I couldn't find any hard-coded logic in https://github.com/rust-lang/rustup-components-history. I think it will just disappear without causing any issues.

IMHO, it should also include a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components in case someone wonders why rls is gone in consecutive nightlies starting from a certain date.

That sounds great but I don't know who maintains it.

@rami3l
Copy link
Member Author

rami3l commented Aug 12, 2024

IMHO, it should also include a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components in case someone wonders why rls is gone in consecutive nightlies starting from a certain date.

That sounds great but I don't know who maintains it.

cc @Mark-Simulacrum @mexus

@Mark-Simulacrum
Copy link
Member

I'm happy to merge small PRs to rustup-components-history.

src/dist/mod.rs Show resolved Hide resolved
@rami3l rami3l added this pull request to the merge queue Aug 20, 2024
Merged via the queue into rust-lang:master with commit c91692a Aug 20, 2024
27 checks passed
@rami3l rami3l deleted the feat/missing-components-pt-2 branch August 20, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants