Guard against overflowing GitHub ID comments #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we overflowed the comment ID counter for comments on GitHub. This causes some comment IDs from this URL https://rfcbot.rs/api/all to be invalid. This patch is a follow-up to this commit rust-lang/rfcbot-rs@f9d84fa to avoid some tooling (notably meetings agenda generators) crashing when retrieving comments with invalid IDs. More info about this incident at: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/rfcbot.20asleep/near/442898636
|
review plssss 🙇♂️ who can have a loook at this? |
ehuss
reviewed
Jul 2, 2024
| // We blew out the GH comment incremental counter (a i32 on their end) | ||
| // See: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/rfcbot.20asleep | ||
| log::debug!("Ignoring overflowed comment id from GitHub"); | ||
| ("".to_string(), "".to_string()) |
There was a problem hiding this comment.
I don't fully understand why this is using empty strings. But I'll trust since I assume you do most of the agenda stuff that it works for you.
There was a problem hiding this comment.
yes it's a bit of a hack and I am not either very fond of this. initiating_comment_html_url and initiating_comment_content are mandatory fields in FCPDetails, so the minimal change I could think of was to set them to an empty string rather than making them Option<String> and deal with a widerspread change in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we overflowed the ID counter for comments on GitHub.
This causes some comment IDs from this URL https://rfcbot.rs/api/all to be negative numbers.
This patch is a follow-up to this commit rust-lang/rfcbot-rs@f9d84fa to avoid some tooling (notably meetings agenda generators) crashing when retrieving comments with invalid IDs. It will not retrieve a comment that has an invalid ID (e.g.
-2132153390)More info about this incident at: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/rfcbot.20asleep/near/442898636
cc: @traviscross (we discussed this)
r? @jackh726 (thanks!)