Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against overflowing GitHub ID comments #1821

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Guard against overflowing GitHub ID comments #1821

merged 1 commit into from
Jul 2, 2024

Commits on Jun 12, 2024

  1. Guard against overflowing GitHub ID comments 

    Recently we overflowed the comment ID counter for comments on GitHub.

This causes some comment IDs from this URL https://rfcbot.rs/api/all to be invalid.

This patch is a follow-up to this commit rust-lang/rfcbot-rs@f9d84fa to avoid some tooling (notably meetings agenda generators) crashing when retrieving comments with invalid IDs.

More info about this incident at: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/rfcbot.20asleep/near/442898636
    @apiraino
    apiraino committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    052db39 View commit details
    Browse the repository at this point in the history