Add work queue tracking in triagebot DB#1879
Merged
jackh726 merged 3 commits intorust-lang:masterfrom Jan 16, 2025
Merged
Conversation
Signed-off-by: apiraino <apiraino@users.noreply.github.com>
Add checks in multiple points when identifying or finding an assignee. Filter out team members currently not having capacity, return messages instructing what to do in case the assignment is rejected. Signed-off-by: apiraino <apiraino@users.noreply.github.com>
apiraino
force-pushed
the
assign-prs-based-on-work-queue-take-3
branch
4 times, most recently
from
d917ccf to
886116c
Compare
apiraino
commented
Jan 8, 2025
jackh726
requested changes
Jan 9, 2025
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
Just double checking, we don't have to do anything fancy with the db before merging, right
Contributor
Author
Correct, the DB schema should be already ready to process the review assignments. The case of |
This check is specifically used when assigning from the Github web UI Signed-off-by: apiraino <apiraino@users.noreply.github.com>
apiraino
force-pushed
the
assign-prs-based-on-work-queue-take-3
branch
from
886116c to
5afc243
Compare
8 tasks
jackh726
approved these changes
Jan 16, 2025
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
We talked a bit in DMs - there are certainly things we could do to minimize the risk (bubble up potential db failures instead of expecting, land the db changes separately, fallbacking to existing non-filtering if db failture), but these aren't needed.
Let's land this.
This was referenced Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #1786
This implements the new way of assigning pull requests reviews (designed in #1753). When this PR is merged, PRs in
rust-lang/rustwill be assigned based on user preferences. These can be queried from Zulip (see docs).If no preferences are set, PRs will be just assigned (like always).
There are multiple points where PRs are assigned (via comment or using the GH UI), I've tried to cover all cases, took some time to test them all. The amount of changes reflect that it is not so easy to catch all spots where this happens. I wish I could make a smaller patch but I think this is an all-or-nothing situation where all cases should be handled at once.
Also modified the zulip triagebot command
work showto return the # work queue capacity set by the user. This is helpful in case a PR assignment is rejected. A PR to update the documentation will follow-up after merge of this.If a PR assignment is rejected we will return a message with some context. Examples:
Failed PR assignment to a user:
Failed self-assignment:
r? @jackh726