Improve clarity of the major change acceptance comment#2212
Merged
Kobzol merged 1 commit intorust-lang:masterfrom Oct 28, 2025
Merged
Improve clarity of the major change acceptance comment#2212Kobzol merged 1 commit intorust-lang:masterfrom
Kobzol merged 1 commit intorust-lang:masterfrom
Conversation
fmease
approved these changes
Oct 28, 2025
Kobzol
approved these changes
Oct 28, 2025
Contributor
|
Adding an emoji was not really necessary :-) Please let's keep their usage at a minimum... |
Member
Author
|
I added it to improve the clarity and readability of text. The congratulatory message a big blob of text, adding a small emoji is not the end of world, in particular one that is strongly related to congratulations. (It also IMO makes it clear at first glance, without having the read the text, what the comment is about).
I'm not planning on adding any other emoji. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the clarity of the major change acceptance comment by using GitHub's alert and simplifying the text.
cc @fmease