Skip to content

Improve clarity of the major change acceptance comment #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

Improve clarity of the major change acceptance comment #2212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/handlers/major_change.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,8 @@ async fn try_accept_mcp(

format!(
r"
Progress of this major change will be tracked in the tracking issue at {}#{}.
> [!NOTE]
> Further progress is now tracked over at {}#{}.
",
&issue_repo, tracking_issue.number
)
Expand All @@ -717,11 +718,12 @@ Progress of this major change will be tracked in the tracking issue at {}#{}.
.post_comment(
&ctx.github,
&format!(
r"The final comment period is now complete, this major change is now **accepted**.
{tracking_issue_text}
As the automated representative, I would like to thank the author for their work and everyone else who contributed to this major change proposal.
r"The final comment period is now complete, this major change is now **accepted**. :tada:

*If you think this major change shouldn't have been accepted, feel free to remove the `{}` label and reopen this issue.*",
As the automated representative, I want to express gratitude to the author for their work and everyone else who contributed to this major change proposal.

*If you think this major change shouldn't have been accepted, feel free to remove the `{}` label and reopen this issue.*
{tracking_issue_text}",
&config.accept_label,
),
)
Expand Down
Loading