wayland: Handle axis_value120
scroll events
#4372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be tested with the
application
example, looking at the events shown for mouse wheel movement.wl_pointer::axis_discrete
isn't sent in version 8 or higher ofwl_pointer
. Andsctk
doesn't convert thevalue120
events, so on compositors advertising version 8, only pixel scroll events were being sent.This sends
MouseScrollDelta::LineDelta
with a fractional value, without doing any accumulation. GivenLineDelta
containsf32
values, this presumably is expected?Though it might be good to change the definition of
MouseScrollDelta
to include both discrete and pixel values, when the compositor sends both. I'm not familiar with how this works on non-Wayland backends though.changelog
module if knowledge of this change could be valuable to users