@W-18480483: Flexipage wrapper assess #330

snehaljha-sf · 2025-07-11T14:26:49Z

What does this PR do?

What issues does this PR fix or reference?

messages/assess.json

src/migration/base.ts

sf-kishore-kurri · 2025-07-14T14:14:42Z

package.json

@@ -15,6 +15,7 @@
    "@types/jsdom": "^21.1.7",
    "@types/lodash.chunk": "^4.2.9",
    "@types/shelljs": "^0.8.15",
+    "fast-xml-parser": "^5.2.5",


LWC migration also does XML parsing so do we need new library for XML parsing?

sf-kishore-kurri · 2025-07-14T14:21:25Z

src/utils/resultsbuilder/FlexipageAssessmentReporter.ts

+          'status',
+          flexipageAssessmentInfo.status,
+          false,
+          1,


We should have component name, file reference, assessment status columns along with diff, errors/summary

sf-kishore-kurri · 2025-07-14T14:22:14Z

src/utils/net/index.ts

+        RequestMethod.POST
+      );
+      response.results.forEach((result) => {
+        results.set(result.referenceId, {


is it formatted only or any other changes?

sf-kishore-kurri · 2025-07-14T14:23:56Z

src/utils/XMLUtil.ts

+class XMLUtil {
+  /** XML parser instance configured for Salesforce metadata */
+  private parser: XMLParser;
+  /** XML builder instance configured for formatted output */


common XML parser or specific to flexipage?

specific to flexipage, I'll rename the file and class

sf-kishore-kurri · 2025-07-14T14:25:55Z

src/migration/related/FlexipageMigration.ts

+      .readdirSync(path.join(this.projectPath, 'force-app', 'main', 'default', 'flexipages'))
+      .filter((file) => file.endsWith('.xml'));
+    Logger.info(this.messages.getMessage('successfullyRetrievedFlexiPages', [files.length]));
+    const progressBar = createProgressBar('Migrating', 'Flexipage');


We should add the progress bar logic for other related objects as well, apex, lwc and exp sites

Is this in scope of this story?

Added note to make a note of the task

we can do it later post the story is complete

sf-kishore-kurri · 2025-07-16T17:14:43Z

@snehaljha-sf we should check-in into develop-ga branch

sf-kishore-kurri · 2025-07-16T17:54:23Z

src/migration/related/FlexipageMigration.ts

+          errors: [error instanceof Error ? error.message : JSON.stringify(error)],
+          path: filePath,
+          diff: '',
+          status: 'Errors',


Failed or Error?

sf-kishore-kurri · 2025-07-16T17:56:13Z

src/migration/related/FlexipageMigration.ts

+    if (mode === 'migrate') {
+      fs.writeFileSync(filePath, modifiedContent);


Lets connect on this?

sf-kishore-kurri · 2025-07-16T17:58:02Z

src/utils/flexipage/flexiPageTransformer.ts

+      if (!typeSubtypeLanguage) {
+        throw new Error('target property not found for component ' + item.componentInstance.componentName);
+      }
+      const newProps = createNewProps(typeSubtypeLanguage);


we do have additional properties which we need fill them along with standard ones and also flex card follows differently

sf-kishore-kurri · 2025-07-16T17:58:57Z

src/utils/resultsbuilder/FlexipageAssessmentReporter.ts

+      },
+      {
+        name: 'Can be Automated',
+        count: flexipageAssessmentInfos.filter((info) => info.status === 'Can be Automated').length,


why it is warning here?

sf-kishore-kurri · 2025-07-17T18:38:20Z

test/utils/flexipage/flexiPageTransformer.test.ts

+} from '../../../src/migration/interfaces';
+
+describe('transformFlexipageBundle', () => {
+  const namespace = 'runtime_omnistudio';


here namespace should be the package one for the wrapper, this is wrong

sf-kishore-kurri · 2025-07-17T18:40:20Z

src/utils/flexipage/flexiPageTransformer.ts

+        ...Object.entries(newProps).map(([key, value]: [string, string]) => ({ name: key, value })),
+      ];
+      changes = true;
+      item.componentInstance.componentInstanceProperties = replacedProps;


Need to additional properties along with these ones check the target metadata once

…ipage_wrapper_assess

sf-kishore-kurri · 2025-07-18T12:46:33Z

src/utils/flexipage/flexiPageTransformer.ts

+  // return {
+  //   language: 'English',
+  //   subType: 'OSForCustomLWC',
+  //   theme: 'lightning',


clean up the comment code

sf-kishore-kurri · 2025-07-18T12:48:53Z

src/utils/flexipage/flexiPageTransformer.ts

+    language: migratedScriptName.language || 'English',
+    subType: migratedScriptName.subtype,
+    type: migratedScriptName.type,
+    theme: 'OSForCustomLWC',


why theme is hard coded @snehaljha-sf ?

we need add logic here based on metadata file shared

sf-kishore-kurri · 2025-07-18T12:51:41Z

src/utils/flexipage/flexiPageTransformer.ts

+
+  return {
+    componentName: targetComponentNameFlexCard,
+    identifier: targetIdentifierFlexCard,


we don't need objectApiName and recordId in flexipages

sf-kishore-kurri · 2025-07-18T12:52:26Z

src/utils/interfaces.ts

+
+export interface FlexiPageAssessmentInfo extends FileChangeInfo {
+  errors: string[];
+  status: 'Can be Automated' | 'Errors' | 'No Changes' | 'Complete' | 'Failed';


Do we need "No Changes"

sf-kishore-kurri · 2025-07-18T12:53:32Z

src/utils/resultsbuilder/FlexipageAssessmentReporter.ts

+            rowspan: 1,
+          },
+          {
+            name: 'Status',


this should be assessment status

sf-kishore-kurri

added comments

sf-kishore-kurri

changes looks good to me

messages/migrate.json

src/migration/related/FlexipageMigration.ts

sf-aastha-paruthi · 2025-07-18T14:08:51Z

src/migration/related/FlexipageMigration.ts

+    shell.cd(this.projectPath);
+    sfProject.retrieve(Constants.FlexiPage, this.org.getUsername());
+    const files = fs
+      .readdirSync(path.join(this.projectPath, 'force-app', 'main', 'default', 'flexipages'))


readdirSync will return the immediate contents of the folder. Can you please confirm if flexipages retrieved in the folder don't have nested folder structure.

that's expected

sf-aastha-paruthi · 2025-07-18T14:28:54Z

src/migration/related/FlexipageMigration.ts

+      const filePath = path.join(this.projectPath, 'force-app', 'main', 'default', 'flexipages', file);
+      try {
+        const flexPageAssessmentInfo: FlexiPageAssessmentInfo = this.processFlexiPage(file, filePath, mode);
+        flexPageAssessmentInfos.push(flexPageAssessmentInfo);


If flexPageAssessmentInfo has no changes, are we still showing it in the report?

no, I am filtering it later

sf-aastha-paruthi · 2025-07-18T14:33:37Z

src/commands/omnistudio/migration/migrate.ts

@@ -186,7 +186,8 @@ export default class Migrate extends OmniStudioBaseCommand {
    const relatedObjectMigrationResult = omnistudioRelatedObjectsMigration.migrateAll(objectsToProcess);
    generatePackageXml.createChangeList(
      relatedObjectMigrationResult.apexAssessmentInfos,
-      relatedObjectMigrationResult.lwcAssessmentInfos
+      relatedObjectMigrationResult.lwcAssessmentInfos,


I believe lwc is not supported in this version

that's alright, as it'll be blank with LWC enabled change is already in progress

feat: flexipage wrapper assess for LWCOmniWrapper

4321696

snehaljha-sf requested a review from a team as a code owner July 11, 2025 14:26

chore: adds jsdocs

05c063f

sf-kishore-kurri reviewed Jul 11, 2025

View reviewed changes

messages/assess.json Show resolved Hide resolved

sf-kishore-kurri reviewed Jul 11, 2025

View reviewed changes

messages/assess.json Outdated Show resolved Hide resolved

sf-kishore-kurri reviewed Jul 11, 2025

View reviewed changes

src/migration/base.ts Outdated Show resolved Hide resolved

sf-kishore-kurri reviewed Jul 14, 2025

View reviewed changes

sf-kishore-kurri reviewed Jul 16, 2025

View reviewed changes

sf-kishore-kurri reviewed Jul 17, 2025

View reviewed changes

snehaljha-sf changed the base branch from prerelease/alpha to prerelease/develop-ga July 18, 2025 05:47

snehaljha-sf added 4 commits July 18, 2025 13:02

chore: addressed comments

f9b09e5

Merge remote-tracking branch 'origin/prerelease/develop-ga' into flex…

f94c01d

…ipage_wrapper_assess

feat: flexipage migration with storage

780a2aa

Merge remote-tracking branch 'origin/prerelease/develop-ga' into flex…

ca8a51d

…ipage_wrapper_assess

sf-kishore-kurri reviewed Jul 18, 2025

View reviewed changes

src/utils/resultsbuilder/FlexipageAssessmentReporter.ts Outdated

rowspan: 1,

},

{

name: 'Status',

Copy link

sf-kishore-kurri Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be assessment status

sf-kishore-kurri reviewed Jul 18, 2025

View reviewed changes

feat: addressed comments

ef338cd

snehaljha-sf added 2 commits July 18, 2025 19:15

chore: status label change

12c3e00

chore: test fix

c0465ba

sf-kishore-kurri approved these changes Jul 18, 2025

View reviewed changes

sf-aastha-paruthi approved these changes Jul 18, 2025

View reviewed changes

sf-aastha-paruthi reviewed Jul 18, 2025

View reviewed changes

fix: addressed comments

a3fd1fa

snehaljha-sf merged commit 79449ae into salesforcecli:prerelease/develop-ga Jul 18, 2025
1 check passed

		if (mode === 'migrate') {
		fs.writeFileSync(filePath, modifiedContent);

@W-18480483: Flexipage wrapper assess #330

@W-18480483: Flexipage wrapper assess #330

Uh oh!

Conversation

snehaljha-sf commented Jul 11, 2025

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sf-kishore-kurri commented Jul 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sf-kishore-kurri left a comment

Choose a reason for hiding this comment

Uh oh!

sf-kishore-kurri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!