generated from salesforcecli/plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 12
@W-18480483: Flexipage wrapper assess #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
snehaljha-sf
merged 10 commits into
salesforcecli:prerelease/develop-ga
from
snehaljha-sf:flexipage_wrapper_assess
Jul 18, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4321696
feat: flexipage wrapper assess for LWCOmniWrapper
snehaljha-sf 05c063f
chore: adds jsdocs
snehaljha-sf f9b09e5
chore: addressed comments
snehaljha-sf f94c01d
Merge remote-tracking branch 'origin/prerelease/develop-ga' into flex…
snehaljha-sf 780a2aa
feat: flexipage migration with storage
snehaljha-sf ca8a51d
Merge remote-tracking branch 'origin/prerelease/develop-ga' into flex…
snehaljha-sf ef338cd
feat: addressed comments
snehaljha-sf 12c3e00
chore: status label change
snehaljha-sf c0465ba
chore: test fix
snehaljha-sf a3fd1fa
fix: addressed comments
snehaljha-sf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ export default class Migrate extends OmniStudioBaseCommand { | |
| }), | ||
| relatedobjects: flags.string({ | ||
| char: 'r', | ||
| description: messages.getMessage('apexLwc'), | ||
| description: messages.getMessage('relatedObjectGA'), | ||
| }), | ||
| verbose: flags.builtin({ | ||
| type: 'builtin', | ||
|
|
@@ -126,7 +126,7 @@ export default class Migrate extends OmniStudioBaseCommand { | |
| const isExperienceBundleMetadataAPIProgramaticallyEnabled: { value: boolean } = { value: false }; | ||
| if (relatedObjects) { | ||
| // To-Do: Add LWC to valid options when GA is released | ||
| const validOptions = [Constants.Apex, Constants.ExpSites]; | ||
| const validOptions = [Constants.Apex, Constants.ExpSites, Constants.FlexiPage]; | ||
| objectsToProcess = relatedObjects.split(',').map((obj) => obj.trim()); | ||
| // Validate input | ||
| for (const obj of objectsToProcess) { | ||
|
|
@@ -186,7 +186,8 @@ export default class Migrate extends OmniStudioBaseCommand { | |
| const relatedObjectMigrationResult = omnistudioRelatedObjectsMigration.migrateAll(objectsToProcess); | ||
| generatePackageXml.createChangeList( | ||
| relatedObjectMigrationResult.apexAssessmentInfos, | ||
| relatedObjectMigrationResult.lwcAssessmentInfos | ||
| relatedObjectMigrationResult.lwcAssessmentInfos, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe lwc is not supported in this version
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's alright, as it'll be blank with LWC enabled change is already in progress |
||
| relatedObjectMigrationResult.flexipageAssessmentInfos | ||
| ); | ||
|
|
||
| // POST MIGRATION | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| export class KeyNotFoundInStorageError extends Error { | ||
| public componentType: string; | ||
| public key: string; | ||
|
|
||
| public constructor(key: string, componentType: string) { | ||
| super(`Key ${key} not found in storage`); | ||
| this.key = key; | ||
| this.componentType = componentType; | ||
| } | ||
| } | ||
|
|
||
| export class DuplicateKeyError extends Error { | ||
| public componentType: string; | ||
| public key: string; | ||
|
|
||
| public constructor(key: string, componentType: string) { | ||
| super(`Key ${key} is duplicate in storage`); | ||
| this.key = key; | ||
| this.componentType = componentType; | ||
| } | ||
| } | ||
|
|
||
| export class TargetPropertyNotFoundError extends Error { | ||
| public componentName: string; | ||
|
|
||
| public constructor(componentName: string) { | ||
| super(`Target property not found for component ${componentName}`); | ||
| this.componentName = componentName; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.