Skip to content

Removed inline script in index.html on viya stream app #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

medjedovicm
Copy link
Member

Intent

Removed inline script in index.html on viya stream app. The script was used for prevent redirects in older versions of SAS Viya.

Implementation

Removed in the compile step.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • [] All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@github-actions github-actions bot requested a review from sabhas May 19, 2025 13:09
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.56% 3313/4504
🟡 Branches 60.56% 1313/2168
🟡 Functions 73.74% 674/914
🟢 Lines 82.56% 8453/10238

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/utils/test.ts 84.66% (-1.14% 🔻) 68.12% 77.14% 92.09%
🟡 src/commands/web/web.ts 81.63% 63.16% 100% 78.38%
🟢 src/commands/compile/compileSingleFile.ts 95.83% (-2.08% 🔻) 84% (-4% 🔻) 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 16f4af4

@YuryShkoda YuryShkoda merged commit fe844d4 into main May 19, 2025
3 checks passed
@YuryShkoda YuryShkoda deleted the remove-inline-script-from-viya branch May 19, 2025 14:26
Copy link

🎉 This PR is included in version 4.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants