[sheets-] speed up loading check of max_rows #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulpw
reviewed
Dec 15, 2024
visidata/sheets.py
Outdated
| @@ -303,8 +303,9 @@ def loader(self): | |||
| self.rows = [] | |||
| try: | |||
| with vd.Progress(gerund='loading', total=0): | |||
| m = self.options.max_rows | |||
There was a problem hiding this comment.
prefer to name the local variable max_rows instead.
|
Option lookup is slow. It should be cached, but still, accessing the cache in an inner loop called millions of times is unnecessary. So this is the reasonable fix. |
For a sheet with millions of rows, the inner loop max_rows check was delaying loading time by 60%.
midichef
force-pushed
the
max_rows_speedup
branch
from
4e3c3be to
f6d178a
Compare
saulpw
reviewed
Dec 16, 2024
saulpw
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Okay, thanks for your diligence. I made it >= so we can have the right number of rows and also stop in case it goes over for some reason. (@anjakefala please squash)
|
Oh, good idea. I'll remember to consider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects vd v3.1. After 7c24ffe, loading sheets became much slower. A 2 million row CSV sheet with multiple columns went from 10 seconds to 16 seconds.
I didn't look into the root cause of why
vd.options.max_rowsis so slow. Perhaps that's the proper fix instead?