Skip to content

[sheets-] speed up loading check of max_rows #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anjakefala merged 3 commits into from
Jan 4, 2025
Merged

[sheets-] speed up loading check of max_rows #2636

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6d178a
[sheets-] speed up loading check of max_rows
midichef Dec 14, 2024
fb16436
Update sheets.py
saulpw Dec 24, 2024
b100489
Update sheets.py
saulpw Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions visidata/sheets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,9 @@ def loader(self):
self.rows = []
try:
with vd.Progress(gerund='loading', total=0):
max_rows = self.options.max_rows
for i, r in enumerate(self.iterload()):
if self.precious and i > self.options.max_rows:
if self.precious and i >= max_rows:
break
self.addRow(r)
except FileNotFoundError:
Expand Down Expand Up @@ -1051,8 +1052,9 @@ def loader(self):

self.rows = []
# add the rest of the rows
max_rows = self.options.max_rows
for i, r in enumerate(vd.Progress(itsource, gerund='loading', total=0)):
if self.precious and i > self.options.max_rows:
if self.precious and i >= max_rows:
break
self.addRow(r)

Expand Down
Loading