Skip to content

Fix handling of buckets with disabled bucket notifications #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

Kerkesni
Copy link
Contributor

@Kerkesni Kerkesni commented Jul 7, 2025

  • Added try/catch to _processObjectEntry to catch exception
    and log them before returning an error
  • When bucket notifications are disabled after being enabled,
    the configuration is set to an empty object. Previously, this
    case was not handled properly, leading to crashes as the
    notification producer and processor incorrectly considered the
    configuration available. This fix ensures proper handling of
    empty configurations to prevent such issues.

Issue: BB-697

@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2025

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.35%. Comparing base (4516feb) to head (57a66a0).
Report is 2 commits behind head on development/9.0.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...ensions/notification/NotificationQueuePopulator.js 98.13% <100.00%> (+0.05%) ⬆️
...s/notification/configManager/MongoConfigManager.js 97.87% <100.00%> (+0.07%) ⬆️

... and 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 75.57% <100.00%> (+0.19%) ⬆️
Core Library 79.67% <ø> (-0.57%) ⬇️
Ingestion 70.23% <ø> (ø)
Lifecycle 77.94% <ø> (ø)
Oplog Populator 85.06% <ø> (ø)
Replication 58.55% <ø> (-0.04%) ⬇️
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2655      +/-   ##
===================================================
- Coverage            73.58%   73.35%   -0.23%     
===================================================
  Files                  201      201              
  Lines                13384    13390       +6     
===================================================
- Hits                  9848     9822      -26     
- Misses                3526     3558      +32     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.47% <0.00%> (-0.01%) ⬇️
api:routes 9.28% <0.00%> (-0.01%) ⬇️
bucket-scanner 85.60% <ø> (ø)
ft_test:queuepopulator 8.90% <0.00%> (-1.30%) ⬇️
ingestion 12.55% <0.00%> (-0.01%) ⬇️
lib 7.38% <0.00%> (-0.01%) ⬇️
lifecycle 18.77% <0.00%> (-0.03%) ⬇️
notification 1.07% <9.52%> (+<0.01%) ⬆️
replication 18.52% <0.00%> (-0.01%) ⬇️
unit 49.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e Jul 7, 2025
@scality scality deleted a comment from bert-e Jul 7, 2025
@scality scality deleted a comment from bert-e Jul 7, 2025
@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni changed the base branch from hotfix/9.0.4 to development/9.0 July 7, 2025 12:48
@scality scality deleted a comment from bert-e Jul 7, 2025
@scality scality deleted a comment from bert-e Jul 7, 2025
@scality scality deleted a comment from bert-e Jul 7, 2025
@scality scality deleted a comment from bert-e Jul 7, 2025
@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@Kerkesni Kerkesni changed the title Fix error handling fallback in _processObjectEntry Fix handling of buckets with disabled bucket notifications Jul 7, 2025
@Kerkesni Kerkesni force-pushed the bugfix/BB-697 branch 2 times, most recently from 50ca212 to 3e180c4 Compare July 8, 2025 08:52
@Kerkesni Kerkesni requested a review from williamlardier July 8, 2025 08:54
Kerkesni added 2 commits July 8, 2025 12:16
Added try/catch to _processObjectEntry to catch exception
and log them before returning an error

Issue: BB-697
When bucket notifications are disabled after being enabled,
the configuration is set to an empty object. Previously, this
case was not handled properly, leading to crashes as the
notification producer and processor incorrectly considered the
configuration available. This fix ensures proper handling of
empty configurations to prevent such issues.

Issue: BB-697
@Kerkesni
Copy link
Contributor Author

Kerkesni commented Jul 8, 2025

/approve

@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2025

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/BB-697 into
    development/9.0
  • w/9.1/bugfix/BB-697 will be merged into development/9.1

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2025

Build failed

The build for commit did not succeed in branch w/9.1/bugfix/BB-697

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6

Please check the status of the associated issue BB-697.

Goodbye kerkesni.

The following options are set: approve

@bert-e bert-e merged commit 57a66a0 into development/9.0 Jul 8, 2025
10 checks passed
@bert-e bert-e deleted the bugfix/BB-697 branch July 8, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants