-
Notifications
You must be signed in to change notification settings - Fork 20
Fix handling of buckets with disabled bucket notifications #2655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 3 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.0 #2655 +/- ##
===================================================
- Coverage 73.58% 73.35% -0.23%
===================================================
Files 201 201
Lines 13384 13390 +6
===================================================
- Hits 9848 9822 -26
- Misses 3526 3558 +32
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
50ca212
to
3e180c4
Compare
Added try/catch to _processObjectEntry to catch exception and log them before returning an error Issue: BB-697
When bucket notifications are disabled after being enabled, the configuration is set to an empty object. Previously, this case was not handled properly, leading to crashes as the notification producer and processor incorrectly considered the configuration available. This fix ensures proper handling of empty configurations to prevent such issues. Issue: BB-697
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/9.1/bugfix/BB-697 The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue BB-697. Goodbye kerkesni. The following options are set: approve |
and log them before returning an error
the configuration is set to an empty object. Previously, this
case was not handled properly, leading to crashes as the
notification producer and processor incorrectly considered the
configuration available. This fix ensures proper handling of
empty configurations to prevent such issues.
Issue: BB-697