Skip to content

chore(deps): update scylladb/cassandra-stress docker tag to v3.18.1 #10845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 11, 2025

This PR contains the following updates:

Package Update Change
scylladb/cassandra-stress minor 3.17.3 -> 3.18.1

Release Notes

scylladb/cassandra-stress (scylladb/cassandra-stress)

v3.18.1

Compare Source

What's Changed

Full Changelog: scylladb/cassandra-stress@v3.18.0...v3.18.1

v3.18.0

Compare Source

What's Changed

New Contributors

Full Changelog: scylladb/cassandra-stress@v3.17.5...v3.18.0

v3.17.5

Compare Source

Full Changelog


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@fruch
Copy link
Contributor

fruch commented May 11, 2025

@juliayakovlev @CodeLieutenant

we need to run a perf test with this one, to evaluate the change to newer java version
I would suggest running the week latency and throughput test

@juliayakovlev
Copy link
Contributor

@juliayakovlev @CodeLieutenant

we need to run a perf test with this one, to evaluate the change to newer java version I would suggest running the week latency and throughput test

@fruch do you want to run it in staging, not official test, correct?

@fruch
Copy link
Contributor

fruch commented May 12, 2025

@juliayakovlev @CodeLieutenant
we need to run a perf test with this one, to evaluate the change to newer java version I would suggest running the week latency and throughput test

@fruch do you want to run it in staging, not official test, correct?

yes

@fruch fruch marked this pull request as draft May 12, 2025 18:40
@fruch
Copy link
Contributor

fruch commented May 12, 2025

3.18.0 should be merged into SCT, user profile is broken, we'll need to issue a new version with a fix.

@CodeLieutenant
Copy link
Contributor

3.18.0 should be merged into SCT, user profile is broken, we'll need to issue a new version with a fix.

@fruch @juliayakovlev v3.18.1 will be released in a couple of minutes

@renovate renovate bot force-pushed the renovate/scylladb-cassandra-stress-3.x branch from 49203d0 to 9002618 Compare May 12, 2025 19:03
@CodeLieutenant CodeLieutenant changed the title chore(deps): update scylladb/cassandra-stress docker tag to v3.18.0 chore(deps): update scylladb/cassandra-stress docker tag to v3.18.1 May 12, 2025
@fruch
Copy link
Contributor

fruch commented May 12, 2025

3.18.0 should be merged into SCT, user profile is broken, we'll need to issue a new version with a fix.

@fruch @juliayakovlev v3.18.1 will be released in a couple of minutes

no need to manually change those they would get updated at some point

edit those PRs only if more changes are needed in the code, which is not only change of the version

@fruch fruch added the test-integration Enable running the integration tests suite label May 12, 2025
@renovate renovate bot force-pushed the renovate/scylladb-cassandra-stress-3.x branch from 7c2a553 to 1c928cf Compare May 12, 2025 20:18
@fruch fruch marked this pull request as ready for review June 22, 2025 17:01
@fruch fruch added the test-provision-aws Run provision test on AWS label Jun 22, 2025
@renovate renovate bot force-pushed the renovate/scylladb-cassandra-stress-3.x branch from 1c928cf to d26937b Compare June 22, 2025 17:02
@fruch
Copy link
Contributor

fruch commented Jun 22, 2025

Started the vnodes tests (write/read/mixed) with 2025.2.0~dev-20250427:

To compare with official job results:

I've missed those report, can you help me summarizes it
as in did you notice any issue with this c-s versions, compared to the previous one

@juliayakovlev
Copy link
Contributor

juliayakovlev commented Jun 23, 2025

@fruch

mixed load
c-s version 3.18.1 (https://argus.scylladb.com/tests/scylla-cluster-tests/5547d9f9-03d8-47d1-8a2a-c1ef424a1485)
c-s version 3.17.5 (https://argus.scylladb.com/tests/scylla-cluster-tests/fb53221f-8396-43b0-b28b-bae902fe7ccf)

Max throughput is same for both versions
P99 read / write is good with 3.18.1 c-s version. But we can't be sure that it will be reproduced

C-s version Max throughput P99 read, 450K step P99 write, 450k step
3.17.5 264K 20.10 17.94
3.18.1 264K 4.05 3.55

read load
c-s version 3.18.1 (https://argus.scylladb.com/tests/scylla-cluster-tests/cc48e081-e6bc-40c6-ad0e-006ad5bf355e/results)
c-s version 3.17.5 (https://argus.scylladb.com/tests/scylla-cluster-tests/bdb9b2b2-407f-4fb8-8e66-806558c93df5/results)

Max throughput is higher in 10% with 3.18.1 version
P99 read is higher with 3.18.1 version

C-s version Max throughput P99 read, 600K step P99 read, 700k step
3.17.5 977.5K 38.04 37
3.18.1 873.6K 83.43 141.53

write load
c-s version 3.18.1 (https://argus.scylladb.com/tests/scylla-cluster-tests/176ab82e-e87b-439d-8689-486560594a95)
c-s version 3.17.5 (https://argus.scylladb.com/tests/scylla-cluster-tests/2abb653c-710e-4d2c-a9d0-2330ea0a57ca)

Same results with both versions:

  • very high P99 write latency
  • max throughput similar with both versions: 297K (3.17.5) and 289K (3.18.1)

Conclusion

while ScyllaDB 3.18.1 shows promising improvements in P99 latencies for mixed workloads, its performance under pure read loads is currently inferior to 3.17.5 in terms of both throughput and latency. Pure write workloads remain consistently high in P99 latency across both versions.
Further investigation into the read performance degradation in 3.18.1 and the consistently high write latencies is recommended.

@CodeLieutenant
Copy link
Contributor

@fruch

mixed load c-s version 3.18.1 (https://argus.scylladb.com/tests/scylla-cluster-tests/5547d9f9-03d8-47d1-8a2a-c1ef424a1485) c-s version 3.17.5 (https://argus.scylladb.com/tests/scylla-cluster-tests/fb53221f-8396-43b0-b28b-bae902fe7ccf)

Max throughput is same for both versions P99 read / write is good with 3.18.1 c-s version. But we can't be sure that it will be reproduced

C-s version Max throughput P99 read, 450K step P99 write, 450k step
3.17.5 264K 20.10 17.94
3.18.1 264K 4.05 3.55
read load c-s version 3.18.1 (https://argus.scylladb.com/tests/scylla-cluster-tests/cc48e081-e6bc-40c6-ad0e-006ad5bf355e/results) c-s version 3.17.5 (https://argus.scylladb.com/tests/scylla-cluster-tests/bdb9b2b2-407f-4fb8-8e66-806558c93df5/results)

Max throughput is higher in 10% with 3.18.1 version P99 read is higher with 3.18.1 version

C-s version Max throughput P99 read, 600K step P99 read, 700k step
3.17.5 977.5K 38.04 37
3.18.1 873.6K 83.43 141.53
write load c-s version 3.18.1 (https://argus.scylladb.com/tests/scylla-cluster-tests/176ab82e-e87b-439d-8689-486560594a95) c-s version 3.17.5 (https://argus.scylladb.com/tests/scylla-cluster-tests/2abb653c-710e-4d2c-a9d0-2330ea0a57ca)

Same results with both versions:

  • very high P99 write latency
  • max throughput similar with both versions: 297K (3.17.5) and 289K (3.18.1)

Conclusion

while ScyllaDB 3.18.1 shows promising improvements in P99 latencies for mixed workloads, its performance under pure read loads is currently inferior to 3.17.5 in terms of both throughput and latency. Pure write workloads remain consistently high in P99 latency across both versions. Further investigation into the read performance degradation in 3.18.1 and the consistently high write latencies is recommended.

This is really strange, the only meaningful change in c-s is the driver updates and Java 21 switch, from every benchmark I've seen with Java 21, it shows it's faster then Java 11 in all use-cases. Latency improvement shows that.

@fruch
Copy link
Contributor

fruch commented Jun 23, 2025

@soyacz @CodeLieutenant

next this this kind of assessment should be done prior to merging such a change (or before releasing)

meanwhile please try to repeat the read test with the newer version of c-s, at least 2 more time to see if it's consistent or not.

@soyacz
Copy link
Contributor

soyacz commented Jun 23, 2025

@soyacz @CodeLieutenant

next this this kind of assessment should be done prior to merging such a change (or before releasing)

This makes changes to c-s much more time consuming. And often redundant.

meanwhile please try to repeat the read test with the newer version of c-s, at least 2 more time to see if it's consistent or not.

We cannot make assumptions based on one test - especially comparing to local peak of 977.5K (all time high at that time, which later dropped again to previous results).

@fruch
Copy link
Contributor

fruch commented Jun 23, 2025

@soyacz @CodeLieutenant

next this this kind of assessment should be done prior to merging such a change (or before releasing)

This makes changes to c-s much more time consuming. And often redundant.

Not for even single change, but some changes required such testing, like changing java version used.

meanwhile please try to repeat the read test with the newer version of c-s, at least 2 more time to see if it's consistent or not.

We cannot make assumptions based on one test - especially comparing to local peak of 977.5K (all time high at that time, which later dropped again to previous results).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/2024.1 Need backport to 2024.1 backport/2024.2 Need backport to 2024.2 backport/2025.1 backport/2025.2 dependencies Pull requests that update a dependency file renovate test-integration Enable running the integration tests suite test-provision-aws Run provision test on AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants