build: use dune

[kopecs]

Moves the build from being dependent on a combination of dune and make to just use dune. This should help simplify things and help make using different versions of tree-sitter a bit easier, since they could be included as different dune projects, rather than needing to handle mutating symlinks in this included as a submodule. This also helps to address some version differences that would create issues with that approach (cf. #106).

One issue with the previous approach was that the version of tree-sitter linked against may not have been the downloaded version. For the versions we have historically been on, this should be OK, since the ABI was compatible and our grammars don't have the current tree-sitter.json config file introduced in (circa) v.0.24.0, so generated code should also use ABI 14. But this may soon no longer be true and would become a barrier to updating grammars where upstream requires a more current version.

This also helps improve build caching, since dune is now aware of more of the dependency graph.

Security

• Change has no security implications (otherwise, ping the security team)

[kopecs]

• build: download tree sitter sources in dune #107
• chore: update version #106
• build: use dune #105 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[kopecs]

What is the preferred image here?

[kopecs]

I still need to do more testing and updates for dependent repos which use this as a submodule (since there is some reliance on symlinks to certain makefiles or scripts here :/), but that shouldn't be a barrier to merging this subject to code review.

[yosefAlsuhaibani]

We went talked through this PR in person, seems good. We should think of bumping the submodule in ocaml-tree-sitter-semgrep, it would be nice if we'd wait merging this till the build there succeeds, but also that's just me being paranoid.