build: download tree sitter sources in dune#107
Open
kopecs wants to merge 1 commit intocooper/01-27-chore_update_versionfrom
Open
build: download tree sitter sources in dune#107kopecs wants to merge 1 commit intocooper/01-27-chore_update_versionfrom
kopecs wants to merge 1 commit intocooper/01-27-chore_update_versionfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Moves the download step to dune rules, allowing us to eliminate an extra script. This also means dune is aware of the archive, so can handle caching it directly (understanding a version change invalidates it) without the need for a script to handle this logic.
kopecs
force-pushed
the
cooper/01-28-build_download_tree_sitter_sources_in_dune
branch
from
d827ca8 to
308c430
Compare
kopecs
force-pushed
the
cooper/01-27-chore_update_version
branch
from
3d41420 to
3b95a93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the download step to dune rules, allowing us to eliminate an extra
script. This also means dune is aware of the archive, so can handle caching it
directly (understanding a version change invalidates it) without the need for a
script to handle this logic.
Security