[flask, seer] autofixable flagship error - UnboundLocalError - OPTION 2 [chained] #858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as chained exception (
raise ... from ...
). This way SEs are not confused and will see familiar-ish inventory error. Same can be done for Option 1 (#857)This is designed not to break Critical Experiences (see
validate_inventory
)This is mutually exclusive with Option 1 (#857) we have to pick one or the other depending on which one provides a better Seer demo.
Testing
standard_checkout_fail
http://localhost:3000/?cexp=standard_checkout_fail&se=unboundlocalerror2-cexp-standard_checkout_fail
flagship error, N+1 query
checkout_success
http://localhost:3000/?cexp=checkout_success&se=unboundlocalerror2-cexp-checkout_success
no errors, only N+1 query