Skip to content

[flask, seer] autofixable flagship error - UnboundLocalError - OPTION 2 [chained] #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

realkosty
Copy link
Collaborator

@realkosty realkosty commented Jun 13, 2025

Implemented as chained exception (raise ... from ...). This way SEs are not confused and will see familiar-ish inventory error. Same can be done for Option 1 (#857)

This is designed not to break Critical Experiences (see validate_inventory)

This is mutually exclusive with Option 1 (#857) we have to pick one or the other depending on which one provides a better Seer demo.

Screenshot 2025-06-13 at 4 16 17 PM

Testing

standard_checkout_fail

http://localhost:3000/?cexp=standard_checkout_fail&se=unboundlocalerror2-cexp-standard_checkout_fail

Screenshot 2025-06-13 at 3 50 01 PM

flagship error, N+1 query

checkout_success

http://localhost:3000/?cexp=checkout_success&se=unboundlocalerror2-cexp-checkout_success

Screenshot 2025-06-13 at 3 46 47 PM

no errors, only N+1 query

@realkosty realkosty requested a review from a team as a code owner June 13, 2025 23:08
Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
empower ⬜️ Ignored (Inspect) Jun 13, 2025 11:08pm

@realkosty realkosty requested review from landenai and ndmanvar June 13, 2025 23:08
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 27.42%. Comparing base (d819193) to head (11a70f6).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
flask/src/main.py 0.00% 24 Missing ⚠️
flask/src/db.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
- Coverage   27.76%   27.42%   -0.34%     
==========================================
  Files          41       41              
  Lines        1059     1072      +13     
  Branches      115      115              
==========================================
  Hits          294      294              
- Misses        746      759      +13     
  Partials       19       19              
Flag Coverage Δ
api 6.40% <0.00%> (-0.18%) ⬇️
frontend 44.72% <ø> (ø)
Components Coverage Δ
checkout_module 6.40% <0.00%> (-0.18%) ⬇️
product_component 41.47% <ø> (ø)
Files with missing lines Coverage Δ
flask/src/db.py 0.00% <0.00%> (ø)
flask/src/main.py 0.00% <0.00%> (ø)

@realkosty realkosty changed the title [flask, seer] autofixable flagship error - UnboundLocalError - OPTION 2 [flask, seer] autofixable flagship error - UnboundLocalError - OPTION 2 [chained] Jun 13, 2025
@realkosty realkosty requested review from lukemun and removed request for a team June 13, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant