Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add extra instructions for the pr review agent to make sure the code being tested is not mocked out #62

Merged
merged 2 commits into from
Mar 17, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: add extra instructions for the pr review agent to make sure the …
…code being tested is not mocked out + add another instruction about not just testing type definitions
shanejonas committed Mar 17, 2025
commit e39e62244498f8f45c550d1c6aac23065f01eda2
10 changes: 8 additions & 2 deletions .github/workflows/reusable-node-ci.yml
Original file line number Diff line number Diff line change
@@ -73,8 +73,14 @@ jobs:
pr_reviewer.inline_code_comments: "true"
pr_description.publish_description_as_comment: "false"
pr_description.add_original_user_description: "true"
# pr_reviewer.extra_instructions: "- instruction a\n- instruction b\n..."

pr_reviewer.extra_instructions: |
## Reviewer Instructions
### Unit Tests
- Make sure that the code being tested is not mocked out.
- Make sure that the code being tested is not using any external services.
- Make sure tests cover real functionality, not only type definitions
- `expect()` syntax should be used instead of `assert()`
- If a test is using mocks, ensure its cleaned up after the test
merge-checks:
name: QA merge checks
runs-on: ubuntu-latest