fix: add extra instructions for the pr review agent to make sure the code being tested is not mocked out #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
changed the title
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
shanejonas
force-pushed
the
fix/add-review-instructions
branch
from
d4ddda7 to
cbcacf6
Compare
…code being tested is not mocked out + add another instruction about not just testing type definitions
shanejonas
force-pushed
the
fix/add-review-instructions
branch
2 times, most recently
from
04f404d to
21aecde
Compare
shanejonas
force-pushed
the
fix/add-review-instructions
branch
from
21aecde to
29f8552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
add extra instructions for the pr review agent to make sure the code being tested is not mocked out
PR Type
enhancement, documentation
Description
Add reviewer instructions to ensure code is not mocked.
Ensure unit tests do not use external services.
Changes walkthrough 📝
reusable-node-ci.yml
Add reviewer instructions for unit tests.github/workflows/reusable-node-ci.yml