retain the selected component (if any) when previewing a form configu… #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration and coming back to the designer mode
|
Deals with this issue #2481 |
There was a problem hiding this comment.
Hi @teboho. Please move this logic to the reducer and remove useEffect from the designerMainArea.
… configuration and coming back to the designer mode" This reverts commit 8b68c4e.
preview.-.Made.with.Clipchamp.mp4 |
IvanIlyichev
requested changes
Mar 18, 2025
There was a problem hiding this comment.
Hi @teboho. Please retest it, after switch to the preview mode and back I got an empty properties panel, see below.
Also the isPreview flag is used by the Preview button only, the designer doesn't take it into account and uses form mode during render. Designer should use the isPreview flag otherwise this flag can be removed. Previous implementation (with useEffect) worked because of multiple unneeded re-renders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ration and coming back to the designer mode