Skip to content

retain the selected component (if any) when previewing a form configu… #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

retain the selected component (if any) when previewing a form configu… #2687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8b68c4e
retain the selected component (if any) when previewing a form configu…
teboho Feb 11, 2025
08686c3
Revert "retain the selected component (if any) when previewing a form…
teboho Feb 13, 2025
bb91e07
Merge branch 'main' into users/teboho/collapse-panels-on-preview
teboho Mar 18, 2025
d14901b
Merge branch 'main' into users/teboho/collapse-panels-on-preview
teboho Mar 18, 2025
715dd48
moving the preview retaining selected component code to the formDesigner
teboho Mar 18, 2025
913c258
Merge branch 'main' of https://github.com/teboho/shesha-framework int…
teboho May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions shesha-reactjs/src/providers/formDesigner/contexts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export interface IFormDesignerStateContext {
dataSources: IDataSource[];

isDebug: boolean;
isPreview: boolean;
readOnly: boolean;
formMode: FormMode;

Expand Down Expand Up @@ -106,6 +107,7 @@ export interface IFormDesignerActionsContext {
setValidationErrors: (payload: IFormValidationErrors) => void;

setDebugMode: (isDebug: boolean) => void;
setPreviewMode: (isPreview: boolean) => void;

updateFormSettings: (settings: IFormSettings) => void;

Expand All @@ -130,6 +132,7 @@ export const FORM_DESIGNER_CONTEXT_INITIAL_STATE: IFormDesignerStateContext = {
hasDragged: false,
isDragging: false,
isDebug: false,
isPreview: false,
formSettings: DEFAULT_FORM_SETTINGS,
formFlatMarkup: {
allComponents: {},
Expand Down
8 changes: 7 additions & 1 deletion shesha-reactjs/src/providers/formDesigner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ const FormDesignerProvider: FC<PropsWithChildren<IFormDesignerProviderProps>> =
dispatch(setDebugModeAction(isDebug));
}, [dispatch]);

const setPreviewMode = useCallback((isPreview: boolean) => {
dispatch(setPreviewModeAction(isPreview));
}, [dispatch]);
Comment on lines +191 to +193
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical error: Missing action creator import.

The function attempts to use setPreviewModeAction which hasn't been imported. This is causing a build failure in the pipeline.

Add the missing import for setPreviewModeAction to the imports section of the file (around line 16-39):

import {
  addDataSourceAction,
  componentAddAction,
  componentAddFromTemplateAction,
  componentDeleteAction,
  componentDuplicateAction,
  componentUpdateAction,
  componentUpdateSettingsValidationAction,
  dataPropertyAddAction,
  endDraggingAction,
  endDraggingNewItemAction,
  removeDataSourceAction,
  setActiveDataSourceAction,
  setDebugModeAction,
+ setPreviewModeAction,
  setFlatComponentsAction,
  setFormModeAction,
  setReadOnlyAction,
  setSelectedComponentAction,
  setValidationErrorsAction,
  startDraggingAction,
  startDraggingNewItemAction,
  updateChildComponentsAction,
  updateFormSettingsAction,
  updateToolboxComponentGroupsAction,
} from './actions';
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const setPreviewMode = useCallback((isPreview: boolean) => {
dispatch(setPreviewModeAction(isPreview));
}, [dispatch]);
import {
addDataSourceAction,
componentAddAction,
componentAddFromTemplateAction,
componentDeleteAction,
componentDuplicateAction,
componentUpdateAction,
componentUpdateSettingsValidationAction,
dataPropertyAddAction,
endDraggingAction,
endDraggingNewItemAction,
removeDataSourceAction,
setActiveDataSourceAction,
setDebugModeAction,
setPreviewModeAction,
setFlatComponentsAction,
setFormModeAction,
setReadOnlyAction,
setSelectedComponentAction,
setValidationErrorsAction,
startDraggingAction,
startDraggingNewItemAction,
updateChildComponentsAction,
updateFormSettingsAction,
updateToolboxComponentGroupsAction,
} from './actions';
🧰 Tools
🪛 GitHub Actions: shesha-reactjs-build

[error] 192-192: RollupError TS2552: Cannot find name 'setPreviewModeAction'. Did you mean 'setPreviewMode'? The error occurs at dispatch(setPreviewModeAction(isPreview)).


const startDraggingNewItem = useCallback(() => {
dispatch(startDraggingNewItemAction());
}, [dispatch]);
Expand Down Expand Up @@ -258,6 +262,7 @@ const FormDesignerProvider: FC<PropsWithChildren<IFormDesignerProviderProps>> =
duplicateComponent,
updateComponent,
setDebugMode,
setPreviewMode,
startDraggingNewItem,
endDraggingNewItem,
startDragging,
Expand Down Expand Up @@ -298,7 +303,8 @@ const FormDesignerProvider: FC<PropsWithChildren<IFormDesignerProviderProps>> =
addDataSource,
removeDataSource,
setActiveDataSource,
setReadOnly
setReadOnly,
setPreviewMode,
/* NEW_ACTION_GOES_HERE */
]);

Expand Down
8 changes: 8 additions & 0 deletions shesha-reactjs/src/providers/formDesigner/reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,14 @@ const reducer = handleActions<IFormDesignerStateContext, any>(
isDebug: payload,
};
},
[FormActionEnums.SetPreviewMode]: (state: IFormDesignerStateContext, action: ReduxActions.Action<boolean>) => {
const { payload } = action;

return {
...state,
isPreview: payload,
};
},

[FormActionEnums.StartDraggingNewItem]: (state: IFormDesignerStateContext) => {
return {
Expand Down
Loading