-
Notifications
You must be signed in to change notification settings - Fork 10
chore(formly): set OnPush as default for formly wrappers #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
prasepic
commented
Sep 12, 2025
- I confirm that this MR follows the contribution guidelines.
4e5b39b to
e658b7b
Compare
timowolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the contribution. Why did you not change the SiFormlyWrapperComponent component?
I also do not really understand why you did this change. We also have many other components in the folders fields and structural. Why not changing all or does this not make sense?
I did not change the I did this change because of #668 and also OnPush must be the default for formly anyways starting from v6 https://formly.dev/docs/guide/migration/#1-custom-type-onpush-change-detection. Regarding changing others, they all have to be tested first so that nothing breaks. |
timowolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, this looks good to me.
e658b7b to
51af24c
Compare
|
🎉 This PR is included in version 48.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |