Skip to content

Conversation

@prasepic
Copy link
Member

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@prasepic prasepic requested a review from a team as a code owner September 12, 2025 07:35
@github-actions
Copy link

@prasepic prasepic marked this pull request as draft September 12, 2025 08:25
@prasepic prasepic force-pushed the chore/onpush/formly_wrappers branch 2 times, most recently from 4e5b39b to e658b7b Compare September 15, 2025 05:38
@prasepic prasepic changed the title chore(fomly): set OnPush as default for formly wrappers chore(formly): set OnPush as default for formly wrappers Sep 15, 2025
@prasepic prasepic marked this pull request as ready for review September 15, 2025 07:28
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the contribution. Why did you not change the SiFormlyWrapperComponent component?

I also do not really understand why you did this change. We also have many other components in the folders fields and structural. Why not changing all or does this not make sense?

@timowolf timowolf self-assigned this Sep 15, 2025
@timowolf timowolf added the enhancement Topics that make the project better label Sep 15, 2025
@prasepic
Copy link
Member Author

Many thanks for the contribution. Why did you not change the SiFormlyWrapperComponent component?

I also do not really understand why you did this change. We also have many other components in the folders fields and structural. Why not changing all or does this not make sense?

I did not change the SiFormlyWrapper because it breaks Timo.

I did this change because of #668 and also OnPush must be the default for formly anyways starting from v6 https://formly.dev/docs/guide/migration/#1-custom-type-onpush-change-detection.

Regarding changing others, they all have to be tested first so that nothing breaks.
I wanted to do it one by one.

Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, this looks good to me.

@timowolf timowolf force-pushed the chore/onpush/formly_wrappers branch from e658b7b to 51af24c Compare September 15, 2025 16:05
@timowolf timowolf enabled auto-merge (rebase) September 15, 2025 16:05
@timowolf timowolf merged commit 87c06d5 into main Sep 15, 2025
9 checks passed
@timowolf timowolf deleted the chore/onpush/formly_wrappers branch September 15, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Topics that make the project better released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants