-
Notifications
You must be signed in to change notification settings - Fork 13
feat(angular): update angular starter application to v4 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @danielleroux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Angular starter application, bringing it up to date with version 4 of the Siemens Industrial Experience (iX) framework. The changes encompass a complete new project scaffold, including robust configurations for development, testing (unit and E2E), and internationalization. This addition expands the monorepo's offerings by providing a modern Angular starting point that aligns with the latest iX component library. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Angular starter application, updating it to version 4 of the ix library. This is a substantial addition with many new files. While the overall structure is sound, there are several critical and high-severity issues that need to be addressed. These include dependency mismatches in package.json, potential memory leaks from unclosed subscriptions, bugs in component logic and event handling, and areas where code robustness and maintainability can be improved. Addressing these points will significantly enhance the quality and stability of the starter application.
Based on existing PR: #116
Update to ix verison v4 was performed followed by all migration steps based on: