Toast, Message, Modal fix for ix-angular/standalone, ix-react, ix-vue #2267
Conversation
🦋 Changeset detectedLatest commit: 997d061 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lzeiml
changed the title
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces fixes for Toast, Message, and Modal components across Angular, React, and Vue packages, primarily by ensuring web components are defined before use. The changes look good and address the described issues. I've added a few comments with suggestions to improve maintainability and type safety by reducing code duplication and using stricter types. Specifically, I've pointed out areas in the Angular services where boilerplate can be reduced and consistency can be improved.
packages/angular/common/src/providers/message/message.service.ts
Outdated
Show resolved
Hide resolved
|
💡 What is the current behavior?
Some functions related to toast, message and modal need to be adjusted to call the relevant defineCustomElement().
GitHub Issue Number: #2263, #2060
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)