-
Notifications
You must be signed in to change notification settings - Fork 117
Toast, Message, Modal fix for ix-angular/standalone, ix-react, ix-vue #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lzeiml
wants to merge
14
commits into
main
Choose a base branch
from
bug/3655_missing-define-custom-element
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fbe740b
fix angular/angular-standalone
lzeiml f273eb3
add react/vue functions
lzeiml 5b674e0
Merge branch 'main' into bug/3655_missing-define-custom-element
lzeiml 0887159
refactor
lzeiml c10fc08
adjust examples
lzeiml c42c5a0
fix comments
lzeiml d78f1fb
Create few-cars-shake.md
lzeiml f3d5ac9
fix changeset
lzeiml 95e65e7
fix angular examples
lzeiml 2fccb19
remove useless code
lzeiml 718abcd
remove useless function
lzeiml 00d4a40
fix
lzeiml c93b5b4
Create flat-scissors-greet.md
lzeiml 997d061
Create ten-dots-tell.md
lzeiml File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: 2025 Siemens AG | ||
| * | ||
| * SPDX-License-Identifier: MIT | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| export { MessageService } from './message.service'; |
106 changes: 106 additions & 0 deletions
106
packages/angular/common/src/providers/message/message.service.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| import { Injectable } from '@angular/core'; | ||
| import { MessageConfig, showMessage, TypedEvent } from '@siemens/ix'; | ||
|
|
||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) | ||
| export class MessageService { | ||
| public showMessage<T>(config: MessageConfig<T>): Promise< | ||
| TypedEvent<{ | ||
| actionId: string; | ||
| payload: T; | ||
| }> | ||
| > { | ||
| return showMessage(config); | ||
| } | ||
|
|
||
| public info( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return showMessage.info( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| public warning( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return showMessage.warning( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| public error( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return showMessage.error( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| public success( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return showMessage.success( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| question( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
lzeiml marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return showMessage.question( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { MessageService } from './message.service'; |
125 changes: 125 additions & 0 deletions
125
packages/angular/src/providers/message/message.service.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| import { Injectable } from '@angular/core'; | ||
| import { MessageConfig, TypedEvent } from '@siemens/ix'; | ||
| import { MessageService as BaseMessageService } from '@siemens/ix-angular/common'; | ||
|
|
||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) | ||
| export class MessageService extends BaseMessageService { | ||
| /** | ||
| * Show a message based on MessageConfig | ||
| */ | ||
| public override showMessage<T>(config: MessageConfig<T>): Promise< | ||
| TypedEvent<{ | ||
| actionId: string; | ||
| payload: T; | ||
| }> | ||
| > { | ||
| return super.showMessage(config); | ||
| } | ||
|
|
||
| /** | ||
| * Show an info message | ||
| */ | ||
| public override info( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return super.info( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Show a warning message | ||
| */ | ||
| public override warning( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return super.warning( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Show an error message | ||
| */ | ||
| public override error( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return super.error( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Show a success message | ||
| */ | ||
| public override success( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return super.success( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Show a question message | ||
| */ | ||
| public override question( | ||
| title: string, | ||
| message: string, | ||
| textOkay: string, | ||
| textCancel?: string, | ||
| payloadOkay?: any, | ||
| payloadCancel?: any | ||
| ) { | ||
| return super.question( | ||
| title, | ||
| message, | ||
| textOkay, | ||
| textCancel, | ||
| payloadOkay, | ||
| payloadCancel | ||
| ); | ||
| } | ||
| } | ||
lzeiml marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.