fix: only use trackByProp on row level with strict type #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintankavathia
added
the
breaking-changes
chintankavathia
force-pushed
the
fix/trackbyprop
branch
from
423016f to
d43517c
Compare
fix `DatatableComponent.trackByProp` which always returned undefined on group level by using key as index for group.
BREAKING CHANGE: `DatatableComponent.trackByProp` input now enforce strict type check as key of row.
Before:
// Even though name is not a valid prop on rows it is allowed to be used with `trackByProp`.
```
<ngx-datatable
trackByProp="'name'"
[rows]="[{id: 1}, {id: 2}]"
>
```
After:
Typescript would give compilation error as name is not known property in rows.
chintankavathia
force-pushed
the
fix/trackbyprop
branch
from
d43517c to
437c08a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
DatatableComponent.trackByPropwhich always returned undefined on group level by using key as index for group.BREAKING CHANGE:
DatatableComponent.trackByPropinput now enforce strict type check as key of row.Before:
// Even though name is not a valid prop on rows it is allowed to be used with
trackByProp.After:
Typescript would give compilation error as name is not know property in rows.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: