Skip to content

[WIP] Migrate from callbacks to async/await #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

DominikPalo
Copy link
Member

@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch 2 times, most recently from b8582ac to c018d0f Compare November 28, 2024 15:44
…ft concurrency)

- Rewrote OAuth2 functions to utilize async/await syntax for improved readability and maintainability.
- Leveraged Swift concurrency to streamline asynchronous operations and reduce callback complexity.
…urrency

- Increased the minimum required versions for iOS, tvOS, and watchOS to ensure compatibility with Swift concurrency features.
- Ensures that the framewokr takes full advantage of modern concurrency capabilities.
- See: https://www.hackingwithswift.com/quick-start/concurrency/where-is-swift-concurrency-supported
@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch from c018d0f to c11d5b1 Compare November 29, 2024 14:44
@jozefizso jozefizso linked an issue Nov 29, 2024 that may be closed by this pull request
@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch 7 times, most recently from 1e61d9c to 0408380 Compare April 22, 2025 12:05
@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch 7 times, most recently from b8c398e to 0e33eae Compare April 24, 2025 10:28
Remove also the legacy implementation of `OAuth2CodeGrantLinkedIn` as it depends on no longer supported custom view controller on iOS
@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch 2 times, most recently from 4011397 to 25bb5fd Compare April 24, 2025 11:12
@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch from 25bb5fd to c171ab6 Compare April 24, 2025 11:40
…s result of `doAuthorize` functions

This fixes also the issues with OAuth2DataLoader
@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch 2 times, most recently from fd8e2e4 to 009b90e Compare May 5, 2025 14:58
@DominikPalo DominikPalo force-pushed the feature/PS-22018-Migrate-from-callbacks-to-async-await branch from 009b90e to daf3edd Compare May 5, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code: Refactor the library to use async/await pattern
2 participants