-
Notifications
You must be signed in to change notification settings - Fork 0
[WIP] Migrate from callbacks to async/await #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DominikPalo
wants to merge
17
commits into
main
Choose a base branch
from
feature/PS-22018-Migrate-from-callbacks-to-async-await
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Migrate from callbacks to async/await #21
DominikPalo
wants to merge
17
commits into
main
from
feature/PS-22018-Migrate-from-callbacks-to-async-await
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8582ac
to
c018d0f
Compare
jozefizso
reviewed
Nov 29, 2024
…ft concurrency) - Rewrote OAuth2 functions to utilize async/await syntax for improved readability and maintainability. - Leveraged Swift concurrency to streamline asynchronous operations and reduce callback complexity.
…urrency - Increased the minimum required versions for iOS, tvOS, and watchOS to ensure compatibility with Swift concurrency features. - Ensures that the framewokr takes full advantage of modern concurrency capabilities. - See: https://www.hackingwithswift.com/quick-start/concurrency/where-is-swift-concurrency-supported
c018d0f
to
c11d5b1
Compare
1e61d9c
to
0408380
Compare
b8c398e
to
0e33eae
Compare
Remove also the legacy implementation of `OAuth2CodeGrantLinkedIn` as it depends on no longer supported custom view controller on iOS
4011397
to
25bb5fd
Compare
25bb5fd
to
c171ab6
Compare
…s result of `doAuthorize` functions This fixes also the issues with OAuth2DataLoader
fd8e2e4
to
009b90e
Compare
009b90e
to
daf3edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sli-do.atlassian.net/browse/PS-22018