Identify style properties as experimental #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove location launch context parameter and scope.
Identify the SMART style JSON objects properties as experimental by adding the word "experimental" in italics.
isaacvetter
changed the title
isaacvetter
changed the title
|
Thanks for taking point on this @isaacvetter. Rather than having a separate page for the 'experimental SMART styling attributes', what if we created a separate 'experimental' page that could host all portions of SMART we eventually deem experimental? Also, I think it'd be best to remove the location attribute on a separate pull request so that we can keep the discussion/decisions around these disparate items distinct from one another. |
This reverts commit 42daf76.
isaacvetter
changed the title
instead of experimental SMART styling, per kpshek's comment
|
Hey @kpshek - updated per your suggestionsin April. Please review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove location launch context parameter and scope.