Fix: deduct storage rebate from estimated gas cost in PTBClient #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 faisal-chainlink, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
faisal-chainlink
changed the title
* remove outdated offramp test in favor of execute_test.go * remove outdated client setup from txm test * use time out SDK client in bindings * update onramp integration to use the unified setup for test env * remove /knowledge_base directory in favor of /documentation * put pack the execute offramp test * experiment * disable offramp integration test in favor of E2E tests * remove the offramp integration test in favor of the E2E test now running in CI
|
Hello, @faisal-chainlink! 👋
|
* add validation of token pool config response in offramp execution flow * misc improvements to fetching the latest package ID * misc lint edits
|
Hello, @faisal-chainlink! 👋
|
1 similar comment
|
Hello, @faisal-chainlink! 👋
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
storageRebateis accounted for in gas estimates to avoid over estimating gas feePackageResolver