Skip to content

Fix: deduct storage rebate from estimated gas cost in PTBClient #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

Fix: deduct storage rebate from estimated gas cost in PTBClient #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
fe7241f
deduct storage rebase from gas estimation cost
faisal-chainlink Nov 11, 2025
fc15d54
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 12, 2025
4aa02dc
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 12, 2025
8c44314
if storage rebate failed to get parsed, set it to 0
faisal-chainlink Nov 12, 2025
3bb2f4d
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 13, 2025
0f45458
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 13, 2025
1942a2a
add a check around updating a transaction state into the same value a…
faisal-chainlink Nov 14, 2025
cac3252
update txm tests
faisal-chainlink Nov 14, 2025
400656e
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 14, 2025
7906ada
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 17, 2025
e5febe5
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 20, 2025
1cf0464
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 20, 2025
0bdf105
ensure that gas coins are not locked
faisal-chainlink Nov 20, 2025
cf951e5
fix failing tests
faisal-chainlink Nov 20, 2025
7447391
udpate fake client
faisal-chainlink Nov 20, 2025
a8d967c
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 20, 2025
3c84913
update mock and fake client
faisal-chainlink Nov 21, 2025
33d1266
Chore: misc tests cleanup (#110)
faisal-chainlink Nov 21, 2025
7364d05
update nix checksum
faisal-chainlink Nov 21, 2025
350c674
Merge branch 'develop' into fix/nonevm-2986
faisal-chainlink Nov 21, 2025
67d43ee
Enhancement: improve package id resolution methods (#234)
faisal-chainlink Nov 21, 2025
f3829d0
run binding regen
faisal-chainlink Nov 21, 2025
e4fba32
update integration test
faisal-chainlink Nov 21, 2025
fcf11a9
tidy
faisal-chainlink Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bindings/tests/testenv/testenv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ func (te *TestEnvironment) initialize() error {
te.cleanup()
return fmt.Errorf("timeout waiting for Sui node to be ready")
default:
client := sui.NewSuiClient(fmt.Sprintf("http://localhost:%d", te.rpcPort))
client := sui.NewSuiClientWithCustomClient(fmt.Sprintf("http://localhost:%d", te.rpcPort), &http.Client{
Timeout: HTTPClientTimeout,
})
_, err := client.SuiGetChainIdentifier(context.Background())
if err == nil {
os.Setenv("SUI_RPC_URL", fmt.Sprintf("http://localhost:%d", te.rpcPort))
Expand Down Expand Up @@ -196,7 +198,9 @@ func (te *TestEnvironment) cleanup() {
}

func createClient() sui.ISuiAPI {
return sui.NewSuiClient(fmt.Sprintf("http://localhost:%d", instance.rpcPort))
return sui.NewSuiClientWithCustomClient(fmt.Sprintf("http://localhost:%d", instance.rpcPort), &http.Client{
Timeout: HTTPClientTimeout,
})
}

func createAccount(t *testing.T) (utils.SuiSigner, error) {
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ require (
github.com/ethereum/go-ethereum v1.16.2
github.com/holiman/uint256 v1.3.2
github.com/smartcontractkit/chain-selectors v1.0.72
github.com/smartcontractkit/chainlink-ccip v0.1.1-solana.0.20251006204220-06f2720ee9a0
github.com/smartcontractkit/chainlink-common v0.9.6-0.20251007140624-a242e4bbd3dc
github.com/smartcontractkit/chainlink-deployments-framework v0.47.0
github.com/smartcontractkit/chainlink-sui v0.0.0-20251104205009-00bd79b81471
Expand Down Expand Up @@ -129,6 +128,7 @@ require (
github.com/shopspring/decimal v1.4.0 // indirect
github.com/sigurn/crc16 v0.0.0-20211026045750-20ab5afb07e3 // indirect
github.com/smartcontractkit/chainlink-aptos v0.0.0-20251024142440-51f2ad2652a2 // indirect
github.com/smartcontractkit/chainlink-ccip v0.1.1-solana.0.20251006204220-06f2720ee9a0 // indirect
github.com/smartcontractkit/chainlink-ccip/chains/solana v0.0.0-20250912190424-fd2e35d7deb5 // indirect
github.com/smartcontractkit/chainlink-ccip/chains/solana/gobindings v0.0.0-20250912190424-fd2e35d7deb5 // indirect
github.com/smartcontractkit/chainlink-common/pkg/chipingress v0.0.4 // indirect
Expand Down
Loading
Loading