Add custom validation exception traits in new codegen-traits package
#4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasgin
force-pushed
the
add-custom-validation-traits
branch
2 times, most recently
from
fa6289a to
405eb3b
Compare
drganjoo
approved these changes
Oct 1, 2025
rcoh
reviewed
Oct 1, 2025
...rc/main/kotlin/software/amazon/smithy/rust/codegen/server/traits/ValidationExceptionTrait.kt
Outdated
Show resolved
Hide resolved
jasgin
force-pushed
the
add-custom-validation-traits
branch
2 times, most recently
from
5c47b56 to
2813185
Compare
rcoh
reviewed
Oct 2, 2025
rcoh
approved these changes
Oct 2, 2025
jasgin
force-pushed
the
add-custom-validation-traits
branch
3 times, most recently
from
58171e5 to
df68b50
Compare
jasgin
force-pushed
the
add-custom-validation-traits
branch
from
df68b50 to
4e01c44
Compare
ysaito1001
approved these changes
Oct 3, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Extension of #4317.
This PR will add the traits and the #4317 will be used to add the validation and codegen.
Deferring moving existing traits to this new package to another PR to avoid clashing refactors with features.
Description
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.