Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] Private rebalance repro jar changes #682

Closed
wants to merge 0 commits into from
Closed

[DNM] Private rebalance repro jar changes #682

wants to merge 0 commits into from

Conversation

sfc-gh-rcheng
Copy link
Collaborator

From @sfc-gh-japatel slack convo
2. Lets comment/remove hasSchemaEvolutionPermission from each partition creation.
3. (already exists) Add executionTimeMs in each of open(), close() and startTask APIs

@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #682 (7e9d487) into rcheng-v1.9.4 (0f570ee) will decrease coverage by 0.76%.
The diff coverage is 100.00%.

❗ Current head 7e9d487 differs from pull request most recent head d69e10f. Consider uploading reports for the commit d69e10f to get more accurate results

@@                Coverage Diff                @@
##           rcheng-v1.9.4     #682      +/-   ##
=================================================
- Coverage          87.97%   87.22%   -0.76%     
=================================================
  Files                 50       50              
  Lines               4143     4141       -2     
  Branches             451      450       -1     
=================================================
- Hits                3645     3612      -33     
- Misses               330      366      +36     
+ Partials             168      163       -5
Files Changed Coverage Δ
...m/snowflake/kafka/connector/SnowflakeSinkTask.java 72.19% <100.00%> (ø)
...ctor/internal/streaming/TopicPartitionChannel.java 91.58% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sfc-gh-tzhang
sfc-gh-tzhang reviewed Aug 2, 2023
View reviewed changes
src/main/java/com/snowflake/kafka/connector/SnowflakeSinkTask.java Outdated
final long recordSize = records.size();
if (enableRebalancing && recordSize > 0) {
processRebalancingTest();
}

final long startTime = System.currentTimeMillis();

getSink().insert(records);

logWarningForPutAndPrecommit(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want INFO level log on this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to info - should we add the log level as a configurable param? We've changed the log level for these logs many times...

1/18: customer issue info -> debug
6/8: debug -> info
6/27: info -> debug

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customers can change it to debug if they like.

@sfc-gh-japatel sfc-gh-japatel mentioned this pull request Aug 5, 2023
Closed
@sfc-gh-rcheng sfc-gh-rcheng deleted the rcheng-rebalance-1.9.4 branch August 25, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang left review comments

@sfc-gh-japatel sfc-gh-japatel Awaiting requested review from sfc-gh-japatel

@sfc-gh-tjones sfc-gh-tjones Awaiting requested review from sfc-gh-tjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-rcheng @sfc-gh-japatel @sfc-gh-tzhang