-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1646711 Raise warning whenever MultiIndex is pulled in locally #2258
Merged
sfc-gh-vbudati
merged 4 commits into
main
from
vbudati/SNOW-1646711-raise-multiindex-warnings
Sep 10, 2024
Merged
SNOW-1646711 Raise warning whenever MultiIndex is pulled in locally #2258
sfc-gh-vbudati
merged 4 commits into
main
from
vbudati/SNOW-1646711-raise-multiindex-warnings
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-vbudati
added
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
labels
Sep 10, 2024
sfc-gh-nkrishna
approved these changes
Sep 10, 2024
sfc-gh-helmeleegy
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
We can also add an improvement entry to the changelog for this. |
…ompiler.py Co-authored-by: Doris Lee <[email protected]>
sfc-gh-vbudati
removed
the
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
label
Sep 10, 2024
sfc-gh-dolee
approved these changes
Sep 10, 2024
sfc-gh-vbudati
deleted the
vbudati/SNOW-1646711-raise-multiindex-warnings
branch
September 10, 2024 19:18
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1646711
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Raise a warning whenever a method pulls in a MultiIndex locally - this happens only once.