Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1646711 Raise warning whenever MultiIndex is pulled in locally #2258

Merged
merged 4 commits into from
Sep 10, 2024
Merged

SNOW-1646711 Raise warning whenever MultiIndex is pulled in locally #2258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ba46f7
raise warnings whenever index is pulled in locally
sfc-gh-vbudati Sep 10, 2024
1526324
Merge branch 'main' into vbudati/SNOW-1646711-raise-multiindex-warnings
sfc-gh-vbudati Sep 10, 2024
5492dd6
Update src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_c…
sfc-gh-vbudati Sep 10, 2024
b414892
update changelog
sfc-gh-vbudati Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@
- Create a lazy index from another lazy index without pulling data to client.
- Raised `NotImplementedError` for Index bitwise operators.
- Display a clearer error message when `Index.names` is set to a non-like-like object.
- Raise a warning whenever MultiIndex values are pulled in locally.

#### Bug Fixes

Expand Down
3 changes: 3 additions & 0 deletions src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1708,6 +1708,9 @@ def index(self) -> Union["pd.Index", native_pd.MultiIndex]:
"""
if self.is_multiindex():
# Lazy multiindex is not supported
logging.warning(
"Lazy MultiIndex is not supported. MultiIndex values are evaluated eagerly and pulled out of Snowflake."
)
return self._modin_frame.index_columns_pandas_index()
else:
return pd.Index(query_compiler=self)
Expand Down
Loading