Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1646711 Raise warning whenever MultiIndex is pulled in locally #2258

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

sfc-gh-vbudati
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1646711

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

Raise a warning whenever a method pulls in a MultiIndex locally - this happens only once.

@sfc-gh-vbudati sfc-gh-vbudati added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 10, 2024
@sfc-gh-vbudati sfc-gh-vbudati requested a review from a team as a code owner September 10, 2024 00:08
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sfc-gh-helmeleegy
Copy link
Contributor

We can also add an improvement entry to the changelog for this.

@sfc-gh-vbudati sfc-gh-vbudati removed the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 10, 2024
@sfc-gh-vbudati sfc-gh-vbudati enabled auto-merge (squash) September 10, 2024 19:11
@sfc-gh-vbudati sfc-gh-vbudati merged commit a03da97 into main Sep 10, 2024
39 checks passed
@sfc-gh-vbudati sfc-gh-vbudati deleted the vbudati/SNOW-1646711-raise-multiindex-warnings branch September 10, 2024 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants