Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing blob radius calculation in 2d #2023

Merged

Conversation

shachafl
Copy link
Collaborator

@shachafl shachafl commented Oct 8, 2024

Replaced np.sqrt(3) with np.sqrt(2) when calculating 2d blob radius.
Close issue #2022

@shachafl shachafl linked an issue Oct 8, 2024 that may be closed by this pull request
@shachafl
Copy link
Collaborator Author

@berl , @njmei , can one of you please review this PR?

@shachafl shachafl merged commit 52a65e4 into master Oct 12, 2024
25 checks passed
@shachafl shachafl deleted the 2d-radius-calculation-in-blob-detection-is-incorrect branch October 12, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2d radius calculation in blob detection (blob.py) is incorrect
2 participants