Skip to content

Move the git-sync implementation to operator-rs #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move the git-sync implementation to operator-rs #623

wants to merge 3 commits into from

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented May 7, 2025 •
edited by adwk67
Loading

Description

Move the git-sync implementation to operator-rs

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@siegfriedweber siegfriedweber self-assigned this May 7, 2025
@siegfriedweber siegfriedweber mentioned this pull request May 7, 2025
Open
siegfriedweber
siegfriedweber commented May 8, 2025
View reviewed changes
Cargo.toml
Comment on lines +36 to +38

[patch."https://github.com/stackabletech/operator-rs.git"]
stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "feat/git-sync" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Upgrade to stackable-operator 0.93.0

@siegfriedweber siegfriedweber marked this pull request as ready for review May 8, 2025 14:39
@siegfriedweber siegfriedweber requested a review from a team May 8, 2025 14:39
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering May 8, 2025
@siegfriedweber siegfriedweber mentioned this pull request May 8, 2025
Open
@adwk67 adwk67 requested review from adwk67 and removed request for a team May 9, 2025 11:08
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 9, 2025
adwk67
adwk67 approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant tests (gitsync) are fine. I also ran the airflow demo without any problems (which shouldn't be affected by this PR, but just to be sure). LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siegfriedweber @adwk67