chore: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6000

gabrielmer · 2024-10-28T16:41:10Z

Integrating libwaku's on-demand DNS discovery functionality and implementing discoverAndConnectPeers

Notice that for discoverAndConnectPeers, we have to do it sequentially and not with goroutines, as libwaku doesn't work properly with goroutines for now (because of goroutines spinning up multiple threads and Nim being set up only in one).

This PR will work properly once waku-org/nwaku#3155 is merged, will update the nwaku submodule here once the fix is in master

Important changes:

integrated libwaku's waku_dns_discovery procedure
added test for DNS discovery
implemented discoverAndConnectPeers

Issue waku-org/nwaku#3076

- some minor progress to add nwaku in status-go - nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty - waku_test.go: adapt TestWakuV2Store - add missing shard.go - feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896) - chore_: update nwaku - nwaku bump (#5911) - bump: nwaku - chore: add USE_NWAKU env flag - fix: build libwaku only if needed - feat: testing discovery and dialing with nwaku integration (#5940)

…esult iterator impl (#5971)

…and libwaku test to run (#5986)

github-actions · 2024-10-28T16:41:32Z

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

implement discoverandConnectPeers
adding dns discovery test
test test
initial dns discovery integration

gabrielmer · 2024-10-28T16:41:48Z

wakuv2/nwaku.go

-		}
-	}
+	var addrsToConnect []multiaddr.Multiaddr
+	nameserver := "1.1.1.1"


What should I add here? For sure there's a better option than hardcoding this, but want to know how is it currently done :))

I'd say for now just add TODO-nwaku ;P
Jokes apart (or not) I think the best would be to avoid passing the nameserver parameter and instead, have the complexity of picking up the appropriate dns-server within libwaku.

gabrielmer · 2024-10-28T16:42:25Z

wakuv2/nwaku_test.go

+	time.Sleep(1 * time.Second)
+
+	sampleEnrTree := "enrtree://AMOJVZX4V6EXP7NTJPMAYJYST2QP6AJXYW76IU6VGJS7UVSNDYZG4@boot.prod.status.nodes.status.im"
+	nameserver := "1.1.1.1"


As mentioned above, I think we can avoid passing the nameserver and leave that responsability to libwaku.
Something to be considered once the following is completed: waku-org/nwaku#1490

status-im-auto · 2024-10-28T16:43:08Z

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	`3a03c44`	#1	2024-10-28 16:43:08	~1 min	`tests`	📄`log`
✔️	`3a03c44`	#1	2024-10-28 16:46:18	~4 min	`ios`	📦`zip`
✔️	`3a03c44`	#1	2024-10-28 16:46:31	~5 min	`linux`	📦`zip`
✔️	`3a03c44`	#1	2024-10-28 16:46:47	~5 min	`android`	📦`aar`
✖️	`3a03c44`	#1	2024-10-28 16:48:07	~6 min	`tests-rpc`	📄`log`

codecov · 2024-10-28T16:49:29Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
23	1	22	0

View the top 1 failed tests by shortest run time

tests.test_router.TestTransactionFromRoute test_tx_from_route

Stack Traces | 10.6s run time

tests/test_router.py:114: in test_tx_from_route
    assert tx_details["to"] == user_2.address
E   AssertionError: assert '0x70997970C5...50e0d17dc79C8' == '0x70997970c5...50e0d17dc79c8'
E     - 0x70997970c51812dc3a010c7d01b50e0d17dc79c8
E     ?           ^        ^   ^                ^
E     + 0x70997970C51812dc3A010C7d01b50e0d17dc79C8
E     ?           ^        ^   ^                ^

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Ivansete-status

LGTM! Thanks for it! 🙌 🥳

Ivansete-status · 2024-10-29T11:36:43Z

wakuv2/nwaku.go

-		}
-	}
+	var addrsToConnect []multiaddr.Multiaddr
+	nameserver := "1.1.1.1"


I'd say for now just add TODO-nwaku ;P
Jokes apart (or not) I think the best would be to avoid passing the nameserver parameter and instead, have the complexity of picking up the appropriate dns-server within libwaku.

Ivansete-status · 2024-10-29T11:39:40Z

wakuv2/nwaku_test.go

+	time.Sleep(1 * time.Second)
+
+	sampleEnrTree := "enrtree://AMOJVZX4V6EXP7NTJPMAYJYST2QP6AJXYW76IU6VGJS7UVSNDYZG4@boot.prod.status.nodes.status.im"
+	nameserver := "1.1.1.1"


As mentioned above, I think we can avoid passing the nameserver and leave that responsability to libwaku.
Something to be considered once the following is completed: waku-org/nwaku#1490

gabrielmer · 2024-10-31T10:03:15Z

Closing this PR in favor of #6017

richard-ramos and others added 12 commits October 15, 2024 18:22

feat_: extract storenode cycle to go-waku api

a06eb72

refactor_: decouple go-waku api from go-waku wakunode

d657edf

fix_: rebase

8198ac1

feat(nwaku)_: message publisher and sent verifier (#5966)

d6079c7

feat(nwaku)_: storenode requestor for missing message retrieval and r…

6dd9b20

…esult iterator impl (#5971)

chore_: uncomment code that would allow status-go/go-waku to compile …

ed5a9aa

…and libwaku test to run (#5986)

feat: supporting peer exchange with nwaku (#5983)

8c4c876

initial dns discovery integration

e585a8e

test test

3227a35

adding dns discovery test

8d4ab44

implement discoverandConnectPeers

3a03c44

gabrielmer self-assigned this Oct 28, 2024

gabrielmer commented Oct 28, 2024

View reviewed changes

gabrielmer marked this pull request as ready for review October 28, 2024 16:43

gabrielmer requested review from richard-ramos and Ivansete-status October 28, 2024 16:43

Ivansete-status approved these changes Oct 29, 2024

View reviewed changes

richard-ramos force-pushed the feature/nwaku-in-status branch 2 times, most recently from e829dea to fd9d9f3 Compare October 29, 2024 16:31

gabrielmer mentioned this pull request Oct 31, 2024

feat_: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6017

Merged

3 tasks

gabrielmer closed this Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6000

chore: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6000

gabrielmer commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024

gabrielmer Oct 28, 2024

Ivansete-status Oct 29, 2024

gabrielmer Oct 28, 2024

Ivansete-status Oct 29, 2024 •

edited

Loading

status-im-auto commented Oct 28, 2024 •

edited

Loading

codecov bot commented Oct 28, 2024

Ivansete-status left a comment

Ivansete-status Oct 29, 2024

Ivansete-status Oct 29, 2024 •

edited

Loading

gabrielmer commented Oct 31, 2024

chore: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6000

chore: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6000

Conversation

gabrielmer commented Oct 28, 2024 • edited Loading

github-actions bot commented Oct 28, 2024

gabrielmer Oct 28, 2024

Choose a reason for hiding this comment

Ivansete-status Oct 29, 2024

Choose a reason for hiding this comment

gabrielmer Oct 28, 2024

Choose a reason for hiding this comment

Ivansete-status Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

status-im-auto commented Oct 28, 2024 • edited Loading

Jenkins Builds

codecov bot commented Oct 28, 2024

❌ 1 Tests Failed:

Ivansete-status left a comment

Choose a reason for hiding this comment

Ivansete-status Oct 29, 2024

Choose a reason for hiding this comment

Ivansete-status Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

gabrielmer commented Oct 31, 2024

gabrielmer commented Oct 28, 2024 •

edited

Loading

Ivansete-status Oct 29, 2024 •

edited

Loading

status-im-auto commented Oct 28, 2024 •

edited

Loading

Ivansete-status Oct 29, 2024 •

edited

Loading