-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat_: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6017
Merged
gabrielmer
merged 5 commits into
feature/nwaku-in-status
from
chore-implement-discoverAndConnectPeers-2
Oct 31, 2024
Merged
feat_: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6017
gabrielmer
merged 5 commits into
feature/nwaku-in-status
from
chore-implement-discoverAndConnectPeers-2
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require commits to follow the Conventional Commits, but with
|
Jenkins BuildsClick to see older builds (7)
|
3 tasks
✔️ status-go/prs/android/PR-6017#1 🔹 ~6 min 23 sec 🔹 1d66fff 🔹 📦 android package |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/nwaku-in-status #6017 +/- ##
==========================================================
Coverage ? 0.00%
==========================================================
Files ? 797
Lines ? 107347
Branches ? 0
==========================================================
Hits ? 0
Misses ? 107347
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
richard-ramos
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same PR as #6000 but over the updated base branch (rebase is not working properly in this case)
Integrating libwaku's on-demand DNS discovery functionality and implementing
discoverAndConnectPeers
Notice that for
discoverAndConnectPeers
, we have to do it sequentially and not with goroutines, as libwaku doesn't work properly with goroutines for now (because of goroutines spinning up multiple threads and Nim being set up only in one).Important changes:
waku_dns_discovery
procedurediscoverAndConnectPeers
Issue waku-org/nwaku#3076