Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: integrate on-demand DNS discovery and implement discoverAndConnectPeers #6017

Merged

Conversation

gabrielmer
Copy link

@gabrielmer gabrielmer commented Oct 31, 2024

Same PR as #6000 but over the updated base branch (rebase is not working properly in this case)

Integrating libwaku's on-demand DNS discovery functionality and implementing discoverAndConnectPeers

Notice that for discoverAndConnectPeers, we have to do it sequentially and not with goroutines, as libwaku doesn't work properly with goroutines for now (because of goroutines spinning up multiple threads and Nim being set up only in one).

Important changes:

  • integrated libwaku's waku_dns_discovery procedure
  • added test for DNS discovery
  • implemented discoverAndConnectPeers

Issue waku-org/nwaku#3076

Copy link

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

implement discoverandConnectPeers
test test
initial dns discovery integration

@status-im-auto
Copy link
Member

status-im-auto commented Oct 31, 2024

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 1d66fff #1 2024-10-31 10:01:41 ~1 min tests 📄log
✖️ 1d66fff #1 2024-10-31 10:03:56 ~4 min tests-rpc 📄log
✔️ 1d66fff #1 2024-10-31 10:04:41 ~4 min macos 📦zip
✔️ 1d66fff #1 2024-10-31 10:05:21 ~5 min macos 📦zip
✔️ 1d66fff #1 2024-10-31 10:05:34 ~5 min linux 📦zip
✔️ 1d66fff #1 2024-10-31 10:05:35 ~5 min ios 📦zip
✖️ 1d66fff #1 2024-10-31 10:10:40 ~10 min windows 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 4c81ce9 #2 2024-10-31 10:03:37 ~1 min tests 📄log
✖️ 4c81ce9 #2 2024-10-31 10:09:23 ~4 min tests-rpc 📄log
✔️ 4c81ce9 #2 2024-10-31 10:09:28 ~4 min macos 📦zip
✔️ 4c81ce9 #2 2024-10-31 10:10:48 ~5 min macos 📦zip
✔️ 4c81ce9 #2 2024-10-31 10:11:23 ~5 min ios 📦zip
✔️ 4c81ce9 #2 2024-10-31 10:11:28 ~5 min linux 📦zip
✔️ 4c81ce9 #2 2024-10-31 10:12:42 ~6 min android 📦aar
✖️ 4c81ce9 #2 2024-10-31 10:21:11 ~10 min windows 📦zip
✖️ f4eae16 #3 2024-10-31 14:41:49 ~2 min tests 📄log
✖️ f4eae16 #3 2024-10-31 14:43:37 ~4 min tests-rpc 📄log
✔️ f4eae16 #3 2024-10-31 14:44:33 ~4 min macos 📦zip
✔️ f4eae16 #3 2024-10-31 14:45:06 ~5 min linux 📦zip
✔️ f4eae16 #3 2024-10-31 14:45:16 ~5 min macos 📦zip
✔️ f4eae16 #3 2024-10-31 14:45:37 ~6 min android 📦aar
✔️ f4eae16 #3 2024-10-31 14:46:40 ~7 min ios 📦zip
✖️ f4eae16 #3 2024-10-31 14:50:10 ~10 min windows 📦zip

@status-im-auto
Copy link
Member

✔️ status-go/prs/android/PR-6017#1 🔹 ~6 min 23 sec 🔹 1d66fff 🔹 📦 android package

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/nwaku-in-status@6ac236d). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature/nwaku-in-status    #6017   +/-   ##
==========================================================
  Coverage                           ?    0.00%           
==========================================================
  Files                              ?      797           
  Lines                              ?   107347           
  Branches                           ?        0           
==========================================================
  Hits                               ?        0           
  Misses                             ?   107347           
  Partials                           ?        0           
Flag Coverage Δ
functional 0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrielmer gabrielmer self-assigned this Oct 31, 2024
wakuv2/nwaku.go Outdated Show resolved Hide resolved
@gabrielmer gabrielmer merged commit d17610d into feature/nwaku-in-status Oct 31, 2024
1 of 10 checks passed
@gabrielmer gabrielmer deleted the chore-implement-discoverAndConnectPeers-2 branch October 31, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants