-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add blas/base/sgemm
#2742
Conversation
…/aman-095/2742
/stdlib update-copyright-years |
@aman-095 To reduce the risk of benchmark workflow timeout, let's reduce the max power in the benchmark files to |
@kgryte I tried reducing the max power to 5, but it still takes a lot of time. Can we reduce it further? |
@aman-095 Yeah, reducing to |
@aman-095 Looking at the test fixtures, it is not clear why the strides are changing when parameterizing whether a transpose should be performed. E.g., for
However, for the no-transpose fixture
with the strides for I believe this needs to be addressed across the various test fixtures. For the benchmarks, we handle this correctly. |
@kgryte We use matrices of dimension |
In the test suites I have used matrices:
Now, based on the operation say if we have |
@aman-095 You're right. Thanks for correcting me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @aman-095!
+9000 lines of code, with review! 🙇♂️🚀 |
PR-URL: stdlib-js#2742 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
Progresses #2039.
Description
This RFC proposes to add a routine to perform one of the matrix-matrix operation
C = α*op(A)*op(B) + β*C
whereop(A)
is one of theop(A) = A
, orop(A) = A^T
,α
andβ
are scalars,A
,B
, andC
are matrices, with op(A) anM
byK
matrix, op(B) aK
byN
matrix and C anM
byN
matrix as defined in BLAS Level 3 routines. Specifically adding@stdlib/blas/base/sgemm
is proposed.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers