-
Notifications
You must be signed in to change notification settings - Fork 219
Add action.yml
#671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action.yml
#671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple suggestions inline, otherwise lgtm.
Something we didn't do is test the action. Can you add a new workflow that tests it with its default settings across the OSes we expect it to work on, across :latest and :testing? I think that'd mean four test runs. The action tests should use the :latest and :testing that are already on dockerhub, not try to build from source local. This is because any change in actions has to work with the previous released version anyway. |
Adds action to run quickstart in the form we usually use in our workflows.
Currently supports Linux and Mac (x84-64 only)