Skip to content

Add action.yml #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 25, 2025
Merged

Add action.yml #671

merged 15 commits into from
Mar 25, 2025

Conversation

ifropc
Copy link
Contributor

@ifropc ifropc commented Mar 19, 2025

Adds action to run quickstart in the form we usually use in our workflows.
Currently supports Linux and Mac (x84-64 only)

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Mar 19, 2025
@ifropc ifropc requested review from leighmcculloch and a team March 19, 2025 23:00
@ifropc ifropc linked an issue Mar 19, 2025 that may be closed by this pull request
@ifropc ifropc requested a review from leighmcculloch March 24, 2025 19:41
@ifropc ifropc enabled auto-merge (squash) March 24, 2025 19:41
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions inline, otherwise lgtm.

@ifropc ifropc disabled auto-merge March 25, 2025 21:08
@ifropc ifropc enabled auto-merge (squash) March 25, 2025 21:42
@ifropc ifropc merged commit 3b81ed4 into stellar:master Mar 25, 2025
167 checks passed
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Mar 25, 2025
@leighmcculloch
Copy link
Member

Something we didn't do is test the action.

Can you add a new workflow that tests it with its default settings across the OSes we expect it to work on, across :latest and :testing? I think that'd mean four test runs.

The action tests should use the :latest and :testing that are already on dockerhub, not try to build from source local. This is because any change in actions has to work with the previous released version anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create reusable GHA for quickstart docker
2 participants