fix(vertical-pod-autoscaler): Update secretName for the TLS cert mount

[featherbread]

When a custom issuer is used, the secret name and issuer name are no longer guaranteed to align. Fixes #1137.

Testing

I've tried deploying this internally, and it turns out our normal ClusterIssuer requires a common name on every certificate, which I'll have to look into separately. In the meantime, I have some sample commands to show off the diff between the chart versions.

Enabling cert-manager with the default issuer

git checkout main && \
  helm template vertical-pod-autoscaler ./charts/vertical-pod-autoscaler \
  --set admissionController.certManager.enabled=true \
  > old.yaml
git checkout vpa-custom-issuer-secret-name && \
  helm template vertical-pod-autoscaler ./charts/vertical-pod-autoscaler \
  --set admissionController.certManager.enabled=true \
  > new.yaml
diff -u old.yaml new.yaml

…produces no output, as expected.

Enabling cert-manager with a custom issuer

git checkout main && \
  helm template vertical-pod-autoscaler ./charts/vertical-pod-autoscaler \
  --set admissionController.certManager.enabled=true \
  --set admissionController.certManager.issuerName=my-custom-issuer \
  > old.yaml
git checkout vpa-custom-issuer-secret-name && \
  helm template vertical-pod-autoscaler ./charts/vertical-pod-autoscaler \
  --set admissionController.certManager.enabled=true \
  --set admissionController.certManager.issuerName=my-custom-issuer \
  > new.yaml
diff -u old.yaml new.yaml

…produces the following:

--- old.yaml    2025-03-04 11:35:46
+++ new.yaml    2025-03-04 11:35:53
@@ -619,7 +619,7 @@
       volumes:
         - name: tls-certs
           secret:
-            secretName: my-custom-issuer
+            secretName: vertical-pod-autoscaler-admission-controller-cert
 ---
 # Source: vertical-pod-autoscaler/templates/recommender/deployment.yaml
 apiVersion: apps/v1

…which matches what grep -A20 'kind: Certificate' new.yaml shows is the certificate name:

kind: Certificate
metadata:
  name: vertical-pod-autoscaler-admission-controller
# ...
  issuerRef:
    kind: Issuer
    name: my-custom-issuer
  secretName: vertical-pod-autoscaler-admission-controller-cert

Release

I can cut a separate PR for a v1.8.1 release (similar to how #1111 released a fix for this chart from #1106), or if it would be easier I'm happy to inline those bumps into this PR.

[stevehipwell]

Thanks for the PR @ahamlinman, do you want to add the release changes into this PR? FYI since the last VPA release I've automated the chart changes annotations so that can be skipped.

[featherbread]

Those changes should be in now, and all references to 1.8.0 should be up to date:

$ rg -F 1.8.0 charts/vertical-pod-autoscaler/
charts/vertical-pod-autoscaler/CHANGELOG.md
23:## [v1.8.0] - 2025-02-14
136:[v1.8.0]: https://github.com/stevehipwell/helm-charts/releases/tag/vertical-pod-autoscaler-1.8.0

[stevehipwell]

Just a minor typo to fix in the CHANGELOG.

[stevehipwell]

Sorry, but the date now needs changing.

[stevehipwell]

@ahamlinman could you also rebase?

[stevehipwell]

LGTM