bug(file): downloading zip exceeding 4gb crashes app #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than 4gb will crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is my first time contributing to an open source software, and it's also my first time working with nest, so please let me know if I'm not following best practices!
This PR fixes #708
This bug occurs because the ZIP file size exceeds the maximum buffer size that Node.js can handle in a single chunk.
I have removed the buffer conversion that was causing this bug, so that we directly return the readable stream from the storage service.
I have tested locally for shares larger than 4gb, and it doesn't crash now. The function
streamToUint8Arrayis now unused, but I'm not sure if it will be used in the future, so I've left it in for now.