Skip to content
This repository was archived by the owner on Jun 29, 2025. It is now read-only.

bug(file): downloading zip exceeding 4gb crashes app #709

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/src/file/file.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@ export class FileController {
@Res({ passthrough: true }) res: Response,
@Param("shareId") shareId: string,
) {
const zip = await this.fileService.getZip(shareId);
const zipStream = this.fileService.getZip(shareId);

res.set({
"Content-Type": "application/zip",
"Content-Disposition": contentDisposition(`${shareId}.zip`),
});

return new StreamableFile(zip);
return new StreamableFile(zipStream);
}

@Get(":fileId")
Expand Down
2 changes: 1 addition & 1 deletion backend/src/file/file.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class FileService {

getZip(shareId: string) {
const storageService = this.getStorageService();
return this.streamToUint8Array(storageService.getZip(shareId) as Readable);
return storageService.getZip(shareId) as Readable;
}

private async streamToUint8Array(stream: Readable): Promise<Uint8Array> {
Expand Down