Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(file): downloading zip exceeding 4gb crashes app #709

Merged
merged 1 commit into from
Dec 28, 2024
Merged

bug(file): downloading zip exceeding 4gb crashes app #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/src/file/file.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@ export class FileController {
@Res({ passthrough: true }) res: Response,
@Param("shareId") shareId: string,
) {
const zip = await this.fileService.getZip(shareId);
const zipStream = this.fileService.getZip(shareId);

res.set({
"Content-Type": "application/zip",
"Content-Disposition": contentDisposition(`${shareId}.zip`),
});

return new StreamableFile(zip);
return new StreamableFile(zipStream);
}

@Get(":fileId")
Expand Down
2 changes: 1 addition & 1 deletion backend/src/file/file.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class FileService {

getZip(shareId: string) {
const storageService = this.getStorageService();
return this.streamToUint8Array(storageService.getZip(shareId) as Readable);
return storageService.getZip(shareId) as Readable;
}

private async streamToUint8Array(stream: Readable): Promise<Uint8Array> {
Expand Down