fix: style validation function error #2711
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2710
Summary
Currently there is a bug that prevents the validation with the styles. This bug happens because it is invoking a method from a string when the object is not a string. To fix that, it is applied a .toString() to the object before the other methods are call.
Also, there is a second bug. This one affects the style Matrix. When the field has some uppercase letter (like camelCase), the name of the field from the OpenAPI is totally in lowercase. This name of the field is compared with the name of the field in the request, which is not applied this lowercase to all of its letters, meaning that even if is written, for example, nameId in the OpenAPI and it is sent nameId in the request, it always fail due comparing nameid to nameId. To fix that, it is applied a lowercase also to request field name. Ideally, the solution would be to not lowercase the field name from the OpenAPI, but my knowledge of the system is not so deep to implement that solution.
Checklist