Skip to content

fix: style validation function error #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+7 −7
Open

fix: style validation function error #2711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd5fee6
Fix function not found
danielferromeral Aug 21, 2025
e9e73b6
Fix function not found
danielferromeral Aug 21, 2025
7348b33
Fix function not found
danielferromeral Aug 21, 2025
1b1051b
Fix type
danielferromeral Aug 21, 2025
0feec22
Fix typo
danielferromeral Aug 21, 2025
1307d27
Fix tests
danielferromeral Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/http/src/validator/deserializers/style/label.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ export function deserializeLabelStyle(
): unknown {
const type = schema ? schema.type : 'undefined';

if (!parameters[name].startsWith('.')) {
if (!parameters[name].toString().startsWith('.')) {
throw new Error('Label serialization style requires parameter to be prefixed with "."');
}

const value = parameters[name].substr(1);
const value = parameters[name].toString().substring(1);

if (type === 'array') {
return deserializeArray(value, explode);
Expand Down
8 changes: 4 additions & 4 deletions packages/http/src/validator/deserializers/style/matrix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ export function deserializeMatrixStyle(
): unknown {
const type = schema ? schema.type : 'undefined';

if (!parameters[name].startsWith(';')) {
if (!parameters[name].toString().startsWith(';')) {
throw new Error('Matrix serialization style requires parameter to be prefixed with ";"');
}

const value = parameters[name].substr(1);
const value = parameters[name].substring(1);

if (type === 'array') {
return explode ? deserializeImplodeArray(name, value) : deserializeArray(name, value);
Expand All @@ -28,11 +28,11 @@ export function deserializeMatrixStyle(

function deserializePrimitive(name: string, value: string) {
const prefix = name + '=';
if (!value.startsWith(prefix)) {
if (!value.toLowerCase().startsWith(prefix)) {
throw new Error('Matrix serialization style requires parameter to be prefixed with name');
}

return value.substr(prefix.length);
return value.substring(prefix.length);
}

function deserializeArray(name: string, value: string) {
Expand Down
2 changes: 1 addition & 1 deletion packages/http/src/validator/deserializers/style/simple.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export function deserializeSimpleStyle(
explode?: boolean
): unknown {
const type = schema ? schema.type : 'undefined';
const value = parameters[name];
const value = parameters[name] == undefined ? parameters[name] : parameters[name].toString();

if (type === 'array') {
return deserializeArray(value);
Expand Down
Loading