[LiPS] Verification dialog / full screen design adjustments

[carlosmuvi-stripe]

Summary

• Adjusts dialog to latest designs. See Figma for reference.

light.mp4

Motivation

https://jira.corp.stripe.com/browse/LINK_MOBILE-188

Testing

• Added tests
• Modified tests
• Manually verified

Screenshots

Before	After
before screenshot	after screenshot

Changelog

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │   2.1 MiB │   2.1 MiB │ +74 B │   4.3 MiB │   4.3 MiB │ +192 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │    0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │    0 B 
      res │ 302.9 KiB │ 302.9 KiB │   0 B │   457 KiB │   457 KiB │    0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │    0 B 
    asset │   7.7 KiB │   7.7 KiB │   0 B │   7.4 KiB │   7.4 KiB │    0 B 
    other │  95.7 KiB │  95.7 KiB │  -6 B │ 183.5 KiB │ 183.5 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │   9.8 MiB │   9.8 MiB │ +68 B │  21.8 MiB │  21.8 MiB │ +192 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 20668 │ 20669 │ +1 (+6 -5) 
   types │  6496 │  6496 │  0 (+0 -0) 
 classes │  5261 │  5261 │  0 (+0 -0) 
 methods │ 31499 │ 31499 │  0 (+5 -5) 
  fields │ 18206 │ 18208 │ +2 (+6 -4) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0

APK

    compressed    │   uncompressed    │                                           
──────────┬───────┼──────────┬────────┤                                           
 size     │ diff  │ size     │ diff   │ path                                      
──────────┼───────┼──────────┼────────┼───────────────────────────────────────────
  2.1 MiB │ +74 B │  4.3 MiB │ +192 B │ ∆ classes.dex                             
 29.2 KiB │  -3 B │ 64.6 KiB │    0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │  -3 B │  1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA                       
    272 B │  +1 B │    120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
 25.9 KiB │  -1 B │ 64.5 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼───────┼──────────┼────────┼───────────────────────────────────────────
  2.1 MiB │ +68 B │  4.4 MiB │ +192 B │ (total)

DEX

STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   20668 │ 20669 │ +1 (+6 -5) 
  
  + , selectedBackground=
  + FZFLII
  + VZLLLLFFLLFLI
  + VZLLLLFFLLFLLI
  + VZLLZL
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"1616daa","r8-mode":"full","version":"8.8.34"}
  
  - FILZ
  - VLLZZL
  - VZLLLLFFLLLI
  - VZLLLLFFLLLLI
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"360944b","r8-mode":"full","version":"8.8.34"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   31499 │ 31499 │ 0 (+5 -5) 
  
  + a.a i(boolean, A, o, a, J, float, float, String, B, float, q, p, int)
  + b4.e a(boolean, float, p, int, int) → float
  + e4.B <init>(long, long, long, long, long)
  + e4.C <init>(boolean, A, o, a, J, float, float, String, B, float, q, int)
  + e4.K <init>(boolean, B, String, boolean, String)
  
  - a.a i(boolean, A, o, a, J, float, float, String, B, q, p, int)
  - b4.e a(int, p, boolean) → float
  - e4.B <init>(long, long, long, long)
  - e4.C <init>(boolean, A, o, a, J, float, float, String, B, q, int)
  - e4.K <init>(B, String, boolean, boolean, String)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   18206 │ 18208 │ +2 (+6 -4) 
  
  + e4.B e: long
  + e4.C Y: float
  + e4.C Z: q
  + e4.K P: boolean
  + e4.K Q: B
  + e4.K R: String
  
  - e4.C Y: q
  - e4.K P: B
  - e4.K Q: String
  - e4.K R: boolean

[carlosmuvi-stripe]

small calculation to ensure we match design paddings keeping the button accessible.

[carlosmuvi-stripe]

Extracted to function because main method was too long.

[carlosmuvi-stripe]

increases border to 1.5 per designs.

[carlosmuvi-stripe]

allows for selected vs unselected bg on the otp.

[carlosmuvi-stripe]

not sure why loading does not show on the screenshot, but it does on device (guessing this is due to AnimatedVisibility)

[tianzhao-stripe]

Whats going on with the screenshot tests?

[carlosmuvi-stripe]

disabled alpha is already applied in the otp component.

[carlosmuvi-stripe]

We'll add this back when adding screenshot tests.

[carlosmuvi-stripe]

The resend loader shows, but Espresso is not able to assert it after moving to LinkSpinner. I'll figure this out, creating a task for it!